Skip to content

chore: no score analysis in facility location status #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triceo merged 1 commit into from
Apr 20, 2026
Merged

chore: no score analysis in facility location status #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion java/facility-location/src/main/java/org/acme/facilitylocation/rest/SolverResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ public SolverResource(FacilityLocationProblemRepository repository,

private Status statusFromSolution(FacilityLocationProblem solution) {
return new Status(solution,
solutionManager.analyze(solution).summarize(),
solverManager.getSolverStatus(PROBLEM_ID));
}
Comment thread
triceo marked this conversation as resolved.

Expand Down
4 changes: 1 addition & 3 deletions java/facility-location/src/main/java/org/acme/facilitylocation/rest/Status.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@

class Status {
public final FacilityLocationProblem solution;
public final String scoreExplanation;
public final boolean isSolving;

Status(FacilityLocationProblem solution, String scoreExplanation, SolverStatus solverStatus) {
Status(FacilityLocationProblem solution, SolverStatus solverStatus) {
this.solution = solution;
this.scoreExplanation = scoreExplanation;
this.isSolving = solverStatus != SolverStatus.NOT_SOLVING;
}
Comment thread
triceo marked this conversation as resolved.
}
3 changes: 1 addition & 2 deletions java/facility-location/src/main/resources/META-INF/resources/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const getFacilityMarker = ({id, location}) => {
return marker;
};

const showProblem = ({solution, scoreExplanation, isSolving}) => {
const showProblem = ({solution, isSolving}) => {
if (!initialized) {
initialized = true;
map.fitBounds(solution.bounds);
Expand Down Expand Up @@ -166,7 +166,6 @@ style="background-color: ${colorIfUsed}; display: inline-block; width: 1rem; hei
$('#cost').text(longCostFormat.format(solution.totalCost));
$('#cost-percentage').text(Math.round(solution.totalCost * 1000 / solution.potentialCost) / 10);
$('#distance').text(solution.totalDistance);
$('#scoreInfo').text(scoreExplanation);
updateSolvingStatus(isSolving);
};

Expand Down
Loading