Skip to content

fix: map correct field#1066

Merged
triceo merged 1 commit into
TimefoldAI:stablefrom
TomCools:fix/constraint-names
Apr 23, 2026
Merged

fix: map correct field#1066
triceo merged 1 commit into
TimefoldAI:stablefrom
TomCools:fix/constraint-names

Conversation

@TomCools

Copy link
Copy Markdown
Collaborator

Description of the change

The ConstraintRef record was changed, but this is what gets exposed if you expose ScoreAnalysis directly.
As a result, currently, the constraint names are not shown when opening the Score Analysis popup in any of the quickstarts.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

The ConstraintRef record was changed, but this is what gets exposed if you expose ScoreAnalysis<Score> directly.
Copilot AI review requested due to automatic review settings April 22, 2026 21:33
@TomCools
TomCools requested a review from triceo as a code owner April 22, 2026 21:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the quickstarts’ Score Analysis popup rendering to use the correct constraint identifier field after the ConstraintRef API change, restoring visible constraint names/IDs in the UI.

Changes:

  • Replace constraintAnalysis.name with constraintAnalysis.id when rendering the “Constraint” column across quickstarts.
  • Apply the same field mapping fix in the shared score-analysis.js used by vehicle-routing.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kotlin/school-timetabling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/vehicle-routing/src/main/resources/META-INF/resources/score-analysis.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/tournament-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/task-assigning/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/spring-boot-integration/src/main/resources/static/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/sports-league-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/school-timetabling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/project-job-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/meeting-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/maintenance-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/food-packaging/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/flight-crew-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/facility-location/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/employee-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/conference-scheduling/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.
java/bed-allocation/src/main/resources/META-INF/resources/app.js Render constraint label using constraintAnalysis.id in Score Analysis table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@triceo
triceo merged commit 5fed0ca into TimefoldAI:stable Apr 23, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants