Skip to content

fix: VRP fix broken tabs#1069

Merged
triceo merged 1 commit into
TimefoldAI:developmentfrom
TomCools:fix/development-vrp-quickstart
Apr 23, 2026
Merged

fix: VRP fix broken tabs#1069
triceo merged 1 commit into
TimefoldAI:developmentfrom
TomCools:fix/development-vrp-quickstart

Conversation

@TomCools

Copy link
Copy Markdown
Collaborator

Description of the change

Same as #1068 but for the development branch.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

Copilot AI review requested due to automatic review settings April 23, 2026 11:50
@TomCools
TomCools requested a review from triceo as a code owner April 23, 2026 11:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Vehicle Routing quickstart UI tabs by ensuring the vis-timeline components render reliably inside Bootstrap tab panes, and improves the timeline panels’ UX with helpful legends and a clearer summary layout.

Changes:

  • Render vis-timelines into dedicated container elements (#byVehicleTimeline, #byVisitTimeline) instead of the entire tab panels.
  • Add timeline legends and move the score display into the “Solution summary” table.
  • Add score formatting and ensure timelines redraw after data refresh when the relevant tab is currently active.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
java/vehicle-routing/src/main/resources/META-INF/resources/index.html Adds timeline legends, introduces dedicated timeline container divs, and relocates the score display into the summary table.
java/vehicle-routing/src/main/resources/META-INF/resources/app.js Initializes timelines on the new container divs, fixes timeline item HTML extraction, formats score display, and triggers redraws when active tabs are updated.
java/vehicle-routing/src/main/java/org/acme/vehiclerouting/rest/VehicleRouteDemoResource.java Updates demo data options (adds GHENT and adjusts parameters).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@triceo triceo changed the title fix: VRP fix broken tabs (#1068) fix: VRP fix broken tabs Apr 23, 2026
@triceo
triceo merged commit 34dfafc into TimefoldAI:development Apr 23, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants