fix: VRP fix broken tabs#1069
Merged
triceo merged 1 commit intoApr 23, 2026
Merged
Conversation
triceo
approved these changes
Apr 23, 2026
There was a problem hiding this comment.
Pull request overview
Fixes the Vehicle Routing quickstart UI tabs by ensuring the vis-timeline components render reliably inside Bootstrap tab panes, and improves the timeline panels’ UX with helpful legends and a clearer summary layout.
Changes:
- Render vis-timelines into dedicated container elements (
#byVehicleTimeline,#byVisitTimeline) instead of the entire tab panels. - Add timeline legends and move the score display into the “Solution summary” table.
- Add score formatting and ensure timelines redraw after data refresh when the relevant tab is currently active.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
java/vehicle-routing/src/main/resources/META-INF/resources/index.html |
Adds timeline legends, introduces dedicated timeline container divs, and relocates the score display into the summary table. |
java/vehicle-routing/src/main/resources/META-INF/resources/app.js |
Initializes timelines on the new container divs, fixes timeline item HTML extraction, formats score display, and triggers redraws when active tabs are updated. |
java/vehicle-routing/src/main/java/org/acme/vehiclerouting/rest/VehicleRouteDemoResource.java |
Updates demo data options (adds GHENT and adjusts parameters). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Same as #1068 but for the development branch.
Checklist
Development
Code Review