Skip to content

fix: centralize the ownership of ValueRangeManager to avoid subtle bugs #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triceo merged 2 commits into from
Jul 28, 2025
Merged

fix: centralize the ownership of ValueRangeManager to avoid subtle bugs #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
144b91d
Remove all uses of VRM
triceo Jul 24, 2025
a88760a
Fix the first cases
triceo Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/main/java/ai/timefold/solver/benchmarks/competitive/AbstractCompetitiveBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@
import ai.timefold.solver.core.api.solver.SolverFactory;
import ai.timefold.solver.core.config.solver.SolverConfig;
import ai.timefold.solver.core.impl.score.director.InnerScore;
import ai.timefold.solver.core.impl.score.director.ValueRangeManager;
import ai.timefold.solver.core.impl.solver.DefaultSolverFactory;
import ai.timefold.solver.core.impl.solver.DefaultSolver;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -198,9 +197,8 @@ private Result<Dataset_, Score_> solveDataset(Configuration_ configuration, Data
LOGGER.info("Started {} ({} / {}), ~{} minute(s) remain in {}.", dataset.name(), dataset.ordinal() + 1,
totalDatasetCount, minutesRemaining, configuration.name());
var bestSolution = solver.solve(solution);
var solutionDescriptor = ((DefaultSolverFactory<Solution_>) solverFactory).getSolutionDescriptor();
var initializationStatistics =
solutionDescriptor.computeInitializationStatistics(bestSolution, new ValueRangeManager<>());
var valueRangeManager = ((DefaultSolver<Solution_>) solver).getSolverScope().getScoreDirector().getValueRangeManager();
var initializationStatistics = valueRangeManager.getInitializationStatistics();
var actualDistance = extractScore(bestSolution);
var innerScore = initializationStatistics.isInitialized() ? InnerScore.fullyAssigned(actualDistance)
: InnerScore.withUnassignedCount(actualDistance, initializationStatistics.getInitCount());
Expand Down
1 change: 0 additions & 1 deletion ...main/java/ai/timefold/solver/benchmarks/micro/scoredirector/problems/AbstractProblem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ public final void setupIteration() {
// Prepare the lifecycle.
var solverScope = new SolverScope<Solution_>();
solverScope.setScoreDirector(scoreDirector);
solverScope.setValueRangeManager(scoreDirector.getValueRangeManager());
solverScope.setWorkingRandom(new Random(0)); // Fully reproducible random selection.
moveRepository.solvingStarted(solverScope);
phaseScope = new LocalSearchPhaseScope<>(solverScope, 0);
Expand Down