sonar

Author: triceo

core/src/main/java/ai/timefold/solver/core/impl/bavet/bi/joiner/BiJoinerComber.java

@@ -56,7 +56,7 @@ Indexing joiner (%s) must not follow a filtering joiner (%s).
             case 1 -> filteringList.getFirst();
             default -> {
                 // Avoid predicate.and() for debugging and potential performance
-                var filteringArray = (BiPredicate<A, B>[]) filteringList.toArray(new BiPredicate[0]);
+                var filteringArray = filteringList.toArray(new BiPredicate[0]);
                 yield (A a, B b) -> {
                     for (var predicate : filteringArray) {
                         if (!predicate.test(a, b)) {

core/src/main/java/ai/timefold/solver/core/impl/bavet/bi/joiner/DefaultBiJoiner.java

@@ -76,7 +76,7 @@ public DefaultBiJoiner<A, B> reorderedEqualsFirst() {
             newJoinerTypes[i] = joinerTypes[from];
             newRightMappings[i] = rightMappings[from];
         }
-        return new DefaultBiJoiner<A, B>(newLeftMappings, newJoinerTypes, newRightMappings);
+        return new DefaultBiJoiner<>(newLeftMappings, newJoinerTypes, newRightMappings);
     }
 
     public Function<A, Object> getLeftMapping(int index) {

core/src/main/java/ai/timefold/solver/core/impl/bavet/common/index/IndexerFactory.java

@@ -562,7 +562,7 @@ public <L, R> FusedEqualIndex<L, R> buildFusedEqualIndex() {
             // Equal prefix + suffix: build the per-side suffix sub-chain (the right side flips comparisons).
             var leftDownstreamSupplier = this.<L> buildIndexerChain(true, 1, LinkedListLeafIndexer::new);
             var rightDownstreamSupplier = this.<R> buildIndexerChain(false, 1, LinkedListLeafIndexer::new);
-            return new FusedEqualIndex<L, R>(topEqualKeyUnpacker, true, leftDownstreamSupplier, rightDownstreamSupplier);
+            return new FusedEqualIndex<>(topEqualKeyUnpacker, true, leftDownstreamSupplier, rightDownstreamSupplier);
         }
     }
 

core/src/main/java/ai/timefold/solver/core/impl/bavet/quad/joiner/DefaultQuadJoiner.java

@@ -77,7 +77,7 @@ DefaultQuadJoiner<A, B, C, D> reorderedEqualsFirst() {
             newJoinerTypes[i] = joinerTypes[from];
             newRightMappings[i] = rightMappings[from];
         }
-        return new DefaultQuadJoiner<A, B, C, D>(newLeftMappings, newJoinerTypes, newRightMappings);
+        return new DefaultQuadJoiner<>(newLeftMappings, newJoinerTypes, newRightMappings);
     }
 
     public TriFunction<A, B, C, Object> getLeftMapping(int index) {

core/src/main/java/ai/timefold/solver/core/impl/bavet/quad/joiner/QuadJoinerComber.java

@@ -57,7 +57,7 @@ Indexing joiner (%s) must not follow a filtering joiner (%s).
             case 1 -> filteringList.getFirst();
             default -> {
                 // Avoid predicate.and() for debugging and potential performance
-                var filteringArray = (QuadPredicate<A, B, C, D>[]) filteringList.toArray(new QuadPredicate[0]);
+                var filteringArray = filteringList.toArray(new QuadPredicate[0]);
                 yield (A a, B b, C c, D d) -> {
                     for (var predicate : filteringArray) {
                         if (!predicate.test(a, b, c, d)) {

core/src/main/java/ai/timefold/solver/core/impl/bavet/tri/joiner/DefaultTriJoiner.java

@@ -77,7 +77,7 @@ DefaultTriJoiner<A, B, C> reorderedEqualsFirst() {
             newJoinerTypes[i] = joinerTypes[from];
             newRightMappings[i] = rightMappings[from];
         }
-        return new DefaultTriJoiner<A, B, C>(newLeftMappings, newJoinerTypes, newRightMappings);
+        return new DefaultTriJoiner<>(newLeftMappings, newJoinerTypes, newRightMappings);
     }
 
     public BiFunction<A, B, Object> getLeftMapping(int index) {

core/src/main/java/ai/timefold/solver/core/impl/bavet/tri/joiner/TriJoinerComber.java

@@ -56,7 +56,7 @@ Indexing joiner (%s) must not follow a filtering joiner (%s).
             case 1 -> filteringList.getFirst();
             default -> {
                 // Avoid predicate.and() for debugging and potential performance
-                var filteringArray = (TriPredicate<A, B, C>[]) filteringList.toArray(new TriPredicate[0]);
+                var filteringArray = filteringList.toArray(new TriPredicate[0]);
                 yield (A a, B b, C c) -> {
                     for (var predicate : filteringArray) {
                         if (!predicate.test(a, b, c)) {

core/src/test/java/ai/timefold/solver/core/impl/bavet/common/joiner/EqualsFirstReorderTest.java

@@ -67,8 +67,7 @@ void equivalentJoinsInDifferentOrderShareViaEquality() {
         assertThat(equalFirst).isNotEqualTo(equalLast);
 
         assertThat(equalFirst.reorderedEqualsFirst()).isEqualTo(equalLast.reorderedEqualsFirst());
-        assertThat(equalFirst.reorderedEqualsFirst().hashCode())
-                .isEqualTo(equalLast.reorderedEqualsFirst().hashCode());
+        assertThat(equalFirst.reorderedEqualsFirst()).hasSameHashCodeAs(equalLast.reorderedEqualsFirst());
     }
 
 }