fix: handle end slash into platform url

Author: cristianonicolai

service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/AbstractPlatformModelMojo.java

@@ -96,6 +96,26 @@ protected void validate() {
         Objects.requireNonNull(key, "Registration key is mandatory");
     }
 
+    /**
+     * Resolves the configured platform URL, stripping any trailing slashes so it can be
+     * safely concatenated with a path that starts with a slash (e.g. "/api/platform/v1/...").
+     */
+    protected String getPlatformUrl() {
+        String url = getPropertyOrParameter(PROP_PLATFORM_URL, this.platformUrl);
+        if (url != null) {
+            url = url.trim();
+            int end = url.length();
+            while (end > 0 && url.charAt(end - 1) == '/') {
+                end--;
+            }
+            url = url.substring(0, end);
+        }
+        if (url == null || url.isEmpty()) {
+            throw new IllegalStateException("Platform Url is mandatory");
+        }
+        return url;
+    }
+
     protected ObjectNode readModelDescriptor(Path modelDescriptorArchivePath) throws IOException {
         Path modelDescriptorPath = Paths.get(buildDirectory, "timefold", DESCRIPTOR_FILE_NAME);
 

service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/ConfigureMojo.java

@@ -152,7 +152,7 @@ private PlatformIdentityInfo fetchPlatformConfiguration() {
         requestBuilder.header("Accept", "application/json");
 
         requestBuilder.header("Authorization", "Bearer " + platformPAT);
-        String platformUrl = getPropertyOrParameter(PROP_PLATFORM_URL, this.platformUrl);
+        String platformUrl = getPlatformUrl();
         requestBuilder.uri(URI.create(platformUrl + "/api/platform/v1/aboutme?includeConfig=true"));
 
         HttpRequest httpRequest = requestBuilder.build();

service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/DeployModelMojo.java

@@ -88,7 +88,7 @@ public void execute() throws MojoExecutionException {
         }
 
         try {
-            String platformUrl = getPropertyOrParameter(PROP_PLATFORM_URL, this.platformUrl);
+            String platformUrl = getPlatformUrl();
             String modelType = getPropertyOrParameter(PRIVATE_MODEL_TYPE, type);
             List<String> tenants = getTenants();
             if (modelType == null) {

service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/UndeployModelMojo.java

@@ -43,7 +43,7 @@ public void execute() throws MojoExecutionException {
         }
 
         try {
-            String platformUrl = getPropertyOrParameter(PROP_PLATFORM_URL, this.platformUrl);
+            String platformUrl = getPlatformUrl();
             String key = getPropertyOrParameter(PROP_MODEL_KEY, this.key);
             Path modelDescriptorArchivePath = Paths.get(buildDirectory, "model-descriptor.zip");
 

service/tools/maven-plugin/src/test/java/ai/timefold/solver/tools/maven/ConfigureMojoTest.java

@@ -137,6 +137,39 @@ public void testConfigureSuccessfully(ConfigureMojo mojo) throws Exception {
                 .containsEntry("image.native-suffix", "");
     }
 
+    @Test
+    @InjectMojo(goal = "configure", pom = "src/test/resources/project-to-test/pom.xml")
+    public void testConfigureSuccessfullyWithTrailingSlashInPlatformUrl(ConfigureMojo mojo) throws Exception {
+
+        session.getRequest().setGoals(List.of("timefold:deploy"));
+
+        mojo.setAccessTokenProvider(new TestAccessTokenProvider("xxxx"));
+        mojo.setLog(log);
+        mojo.platformUrl = wm1.getRuntimeInfo().getHttpBaseUrl() + "/";
+        mojo.execute();
+
+        wm1.verify(1, getRequestedFor(urlPathEqualTo("/api/platform/v1/aboutme")));
+
+        // assert that plugin executed and produced expected logs
+        log.assertContains("Configured Timefold Platform integration", Level.INFO);
+    }
+
+    @Test
+    @InjectMojo(goal = "configure", pom = "src/test/resources/project-to-test/pom.xml")
+    public void testConfigureFailsWithBlankPlatformUrl(ConfigureMojo mojo) throws Exception {
+
+        session.getRequest().setGoals(List.of("timefold:deploy"));
+
+        mojo.setAccessTokenProvider(new TestAccessTokenProvider("xxxx"));
+        mojo.setLog(log);
+        mojo.platformUrl = "///";
+
+        assertThatThrownBy(() -> mojo.execute()).isInstanceOf(IllegalStateException.class)
+                .hasMessage("Platform Url is mandatory");
+
+        wm1.verify(0, getRequestedFor(urlPathEqualTo("/api/platform/v1/aboutme")));
+    }
+
     @Test
     @MojoParameter(name = "nativeSupported", value = "true")
     @InjectMojo(goal = "configure", pom = "src/test/resources/project-to-test/pom.xml")