fix bad refactor

Author: triceo

core/src/main/java/ai/timefold/solver/core/api/score/ScoreExplanation.java

@@ -80,16 +80,16 @@ public interface ScoreExplanation<Solution_, Score_ extends Score<Score_>> {
      *
      * <ul>
      * <li>
-     * With Constraint Streams, the user has an option to provide a custom constraintverifier mapping,
+     * With Constraint Streams, the user has an option to provide a custom justification mapping,
      * implementing {@link ConstraintJustification}.
-     * If provided, every {@link ConstraintMatch} of such constraint will be associated with this custom constraintverifier
+     * If provided, every {@link ConstraintMatch} of such constraint will be associated with this custom justification
      * class.
-     * Every constraint not associated with a custom constraintverifier class
+     * Every constraint not associated with a custom justification class
      * will be associated with {@link DefaultConstraintJustification}.
      * </li>
      * <li>
      * With {@link ConstraintMatchAwareIncrementalScoreCalculator},
-     * every {@link ConstraintMatch} will be associated with the constraintverifier class that the user created it with.
+     * every {@link ConstraintMatch} will be associated with the justification class that the user created it with.
      * </li>
      * </ul>
      *
@@ -102,9 +102,9 @@ public interface ScoreExplanation<Solution_, Score_ extends Score<Score_>> {
      * Explains the {@link Score} of {@link #getScore()} for all constraints
      * justified with a given {@link ConstraintJustification} type.
      * Otherwise, as defined by {@link #getJustificationList()}.
-     * May be empty, if the score explanation ran with constraintverifier support disabled.
+     * May be empty, if the score explanation ran with justification support disabled.
      *
-     * @return all constraint matches associated with the given constraintverifier class
+     * @return all constraint matches associated with the given justification class
      * @see #getIndictmentMap()
      */
     default <ConstraintJustification_ extends ConstraintJustification> List<ConstraintJustification_>

core/src/main/java/ai/timefold/solver/core/api/score/analysis/ConstraintAnalysis.java

@@ -160,9 +160,9 @@ private static int getMatchCount(ConstraintAnalysis<?> analysis, ConstraintAnaly
         for (var matchAnalysis : matchAnalyses) {
             var previous = matchAnalysisMap.put(matchAnalysis.justification(), matchAnalysis);
             if (previous != null) {
-                // Match analysis for the same constraintverifier should have been merged already.
+                // Match analysis for the same justification should have been merged already.
                 throw new IllegalStateException(
-                        "Impossible state: multiple constraint matches (%s, %s) have the same constraintverifier (%s)."
+                        "Impossible state: multiple constraint matches (%s, %s) have the same justification (%s)."
                                 .formatted(previous, matchAnalysis, matchAnalysis.justification()));
             }
         }

core/src/main/java/ai/timefold/solver/core/api/score/analysis/MatchAnalysis.java

@@ -23,8 +23,8 @@ public record MatchAnalysis<Score_ extends Score<Score_>>(ConstraintRef constrai
     public MatchAnalysis {
         Objects.requireNonNull(constraintRef);
         Objects.requireNonNull(score);
-        // Null constraintverifier is impossible;
-        // if the fetch policy doesn't requre match analysis, the code shouldn't even get here.
+        // Null justification is impossible;
+        // if the fetch policy doesn't require match analysis, the code shouldn't even get here.
         Objects.requireNonNull(justification, () -> """
                 Impossible state: Received a null justification.
                 Maybe check your %s's justifyWith() implementation for that constraint?"""

core/src/main/java/ai/timefold/solver/core/api/score/constraint/ConstraintMatch.java

@@ -54,15 +54,15 @@ public ConstraintRef getConstraintRef() {
     }
 
     /**
-     * Return a singular constraintverifier for the constraint.
+     * Return a singular justification for the constraint.
      * <p>
      * This method has a different meaning based on which score director the constraint comes from.
      * <ul>
      * <li>For constraint streams, it returns {@link DefaultConstraintJustification} from the matching tuple
-     * (eg. [A, B] for a bi stream), unless a custom constraintverifier mapping was provided,
+     * (eg. [A, B] for a bi stream), unless a custom justification mapping was provided,
      * in which case it returns the return value of that function.</li>
      * <li>For incremental score calculation, it returns what the calculator is implemented to return.</li>
-     * <li>It may return null, if constraintverifier support was disabled altogether.</li>
+     * <li>It may return null, if justification support was disabled altogether.</li>
      * </ul>
      */
     @SuppressWarnings("unchecked")
@@ -79,7 +79,7 @@ public ConstraintRef getConstraintRef() {
      * (eg. [A, B] for a bi stream), unless a custom indictment mapping was provided,
      * in which case it returns the return value of that function.</li>
      * <li>For incremental score calculation, it returns what the calculator is implemented to return.</li>
-     * <li>It may return an empty list, if constraintverifier support was disabled altogether.</li>
+     * <li>It may return an empty list, if justification support was disabled altogether.</li>
      * </ul>
      *
      * @return may be empty or contain null

core/src/main/java/ai/timefold/solver/core/api/score/constraint/Indictment.java

@@ -50,7 +50,7 @@ default int getConstraintMatchCount() {
 
     /**
      * Retrieve {@link ConstraintJustification} instances associated with {@link ConstraintMatch}es in
-     * {@link #getConstraintMatchSet()}, which are of (or extend) a given constraint constraintverifier implementation.
+     * {@link #getConstraintMatchSet()}, which are of (or extend) a given constraint justification implementation.
      * This is equivalent to retrieving {@link #getConstraintMatchSet()}
      * and collecting all matching {@link ConstraintMatch#getJustification()} objects into a list.
      *

core/src/main/java/ai/timefold/solver/core/api/score/stream/ConstraintBuilder.java

@@ -11,7 +11,7 @@ public interface ConstraintBuilder {
      * Builds a {@link Constraint} from the constraint stream.
      * The constraint will be placed in the {@link Constraint#DEFAULT_CONSTRAINT_GROUP default constraint group}.
      *
-     * @param constraintName shows up in {@link ConstraintMatchTotal} during score constraintverifier
+     * @param constraintName shows up in {@link ConstraintMatchTotal} during score justification
      */
     default Constraint asConstraint(String constraintName) {
         return asConstraintDescribed(constraintName, "");
@@ -21,7 +21,7 @@ default Constraint asConstraint(String constraintName) {
      * As defined by {@link #asConstraintDescribed(String, String, String)},
      * placing the constraint in the {@link Constraint#DEFAULT_CONSTRAINT_GROUP default constraint group}.
      *
-     * @param constraintName shows up in {@link ConstraintMatchTotal} during score constraintverifier
+     * @param constraintName shows up in {@link ConstraintMatchTotal} during score justification
      * @param constraintDescription can contain any character, but it is recommended to keep it short and concise.
      */
     default Constraint asConstraintDescribed(String constraintName, String constraintDescription) {
@@ -38,7 +38,7 @@ default Constraint asConstraintDescribed(String constraintName, String constrain
      * the constraint description is unlikely to be used externally as an identifier,
      * and therefore doesn't need to be URL-friendly, or protected against injection attacks.
      *
-     * @param constraintName shows up in {@link ConstraintMatchTotal} during score constraintverifier
+     * @param constraintName shows up in {@link ConstraintMatchTotal} during score justification
      * @param constraintDescription can contain any character, but it is recommended to keep it short and concise.
      * @param constraintGroup not used by the solver directly, but may be used by external tools to group constraints together,
      *        such as by their source or by their purpose

core/src/main/java/ai/timefold/solver/core/api/score/stream/ConstraintJustification.java

@@ -20,7 +20,7 @@
  *
  * <p>
  * If two instances of this class are {@link Object#equals(Object) equal},
- * they are considered to be the same constraintverifier.
+ * they are considered to be the same justification.
  * This matters in case of {@link SolutionManager#analyze(Object)} score analysis
  * where such justifications are grouped together.
  * This situation is likely to occur in case a {@link ConstraintStream} produces duplicate tuples,

core/src/main/java/ai/timefold/solver/core/api/score/stream/DefaultConstraintJustification.java

@@ -13,7 +13,7 @@
 
 /**
  * Default implementation of {@link ConstraintJustification}, returned by {@link ConstraintMatch#getJustification()}
- * unless the user defined a custom constraintverifier mapping.
+ * unless the user defined a custom justification mapping.
  */
 public final class DefaultConstraintJustification
         implements ConstraintJustification, Comparable<DefaultConstraintJustification> {

core/src/main/java/ai/timefold/solver/core/api/score/stream/bi/BiConstraintBuilder.java

@@ -19,7 +19,7 @@
  * To build the constraint, use one of the terminal operations, such as {@link #asConstraint(String)}.
  * <p>
  * Unless {@link #justifyWith(TriFunction)} is called,
- * the default constraintverifier mapping will be used.
+ * the default justification mapping will be used.
  * The function takes the input arguments and converts them into a {@link java.util.List}.
  * <p>
  * Unless {@link #indictWith(BiFunction)} is called, the default indicted objects' mapping will be used.

core/src/main/java/ai/timefold/solver/core/api/score/stream/quad/QuadConstraintBuilder.java

@@ -18,7 +18,7 @@
  * Used to build a {@link Constraint} out of a {@link QuadConstraintStream}, applying optional configuration.
  * To build the constraint, use one of the terminal operations, such as {@link #asConstraint(String)}.
  * <p>
- * Unless {@link #justifyWith(PentaFunction)} is called, the default constraintverifier mapping will be used.
+ * Unless {@link #justifyWith(PentaFunction)} is called, the default justification mapping will be used.
  * The function takes the input arguments and converts them into a {@link java.util.List}.
  * <p>
  * Unless {@link #indictWith(QuadFunction)} is called, the default indicted objects' mapping will be used.