copilot

Author: triceo

core/src/main/java/ai/timefold/solver/core/impl/bavet/common/tuple/ActivitySupport.java

@@ -95,7 +95,7 @@ public interface ActivitySupport {
      * @return true if this lifecycle can produce tuples
      */
     default boolean isActive() {
-        throw new IllegalStateException("Impossible state: node (%s) not yet called initialized."
+        throw new IllegalStateException("Impossible state: node (%s) not yet initialized (afterAllFactsInserted not called)."
                 .formatted(this));
     }
 

core/src/main/java/ai/timefold/solver/core/impl/neighborhood/stream/enumerating/DatasetSession.java

@@ -4,9 +4,9 @@
 import java.util.Map;
 import java.util.Objects;
 
-import ai.timefold.solver.core.impl.bavet.AbstractBavetNodeNetwork;
 import ai.timefold.solver.core.impl.bavet.AbstractSession;
 import ai.timefold.solver.core.impl.bavet.common.tuple.UniTuple;
+import ai.timefold.solver.core.impl.neighborhood.NeighborhoodsBavetNodeNetwork;
 import ai.timefold.solver.core.impl.neighborhood.stream.enumerating.common.AbstractDataset;
 import ai.timefold.solver.core.impl.neighborhood.stream.enumerating.common.AbstractDatasetInstance;
 import ai.timefold.solver.core.impl.neighborhood.stream.enumerating.common.AbstractLeftDataset;
@@ -17,14 +17,15 @@
 import org.jspecify.annotations.NullMarked;
 
 @NullMarked
-public final class DatasetSession<Solution_> extends AbstractSession {
+public final class DatasetSession<Solution_>
+        extends AbstractSession<NeighborhoodsBavetNodeNetwork> {
 
     private final Map<AbstractDataset<Solution_>, AbstractDatasetInstance<Solution_, ?>> leftDatasetInstanceMap =
             new IdentityHashMap<>();
     private final Map<AbstractDataset<Solution_>, AbstractDatasetInstance<Solution_, ?>> rightDatasetInstanceMap =
             new IdentityHashMap<>();
 
-    DatasetSession(AbstractBavetNodeNetwork nodeNetwork) {
+    DatasetSession(NeighborhoodsBavetNodeNetwork nodeNetwork) {
         super(nodeNetwork);
     }
 

core/src/main/java/ai/timefold/solver/core/impl/neighborhood/stream/enumerating/DatasetSessionFactory.java

@@ -6,9 +6,9 @@
 import java.util.List;
 import java.util.Set;
 
-import ai.timefold.solver.core.impl.bavet.AbstractBavetNodeNetwork;
 import ai.timefold.solver.core.impl.bavet.common.AbstractRootNode;
 import ai.timefold.solver.core.impl.bavet.uni.AbstractForEachUniNode;
+import ai.timefold.solver.core.impl.neighborhood.NeighborhoodsBavetNodeNetwork;
 import ai.timefold.solver.core.impl.neighborhood.stream.enumerating.common.AbstractEnumeratingStream;
 import ai.timefold.solver.core.impl.neighborhood.stream.enumerating.common.DataNodeBuildHelper;
 import ai.timefold.solver.core.impl.score.director.SessionContext;
@@ -38,7 +38,7 @@ public DatasetSession<Solution_> buildSession(SessionContext<Solution_> context)
         return session;
     }
 
-    private AbstractBavetNodeNetwork buildNodeNetwork(Set<AbstractEnumeratingStream<Solution_>> enumeratingStreamSet,
+    private NeighborhoodsBavetNodeNetwork buildNodeNetwork(Set<AbstractEnumeratingStream<Solution_>> enumeratingStreamSet,
             DataNodeBuildHelper<Solution_> buildHelper) {
         var declaredClassToNodeMap = new LinkedHashMap<Class<?>, List<AbstractRootNode<?>>>();
         var nodeList = buildHelper.buildNodeList(enumeratingStreamSet, buildHelper,

core/src/main/java/ai/timefold/solver/core/impl/neighborhood/stream/enumerating/common/AbstractDatasetInstance.java

@@ -13,6 +13,7 @@ public abstract class AbstractDatasetInstance<Solution_, Tuple_ extends Tuple>
 
     private final AbstractDataset<Solution_> parent;
     protected final int entryStoreIndex;
+    private boolean upstreamCanProduceTuples;
 
     protected AbstractDatasetInstance(AbstractDataset<Solution_> parent, int entryStoreIndex) {
         this.parent = Objects.requireNonNull(parent);
@@ -21,12 +22,12 @@ protected AbstractDatasetInstance(AbstractDataset<Solution_> parent, int entrySt
 
     @Override
     public void afterAllFactsInserted(boolean upstreamCanProduceTuples) {
-        // TODO implement
+        this.upstreamCanProduceTuples = upstreamCanProduceTuples;
     }
 
     @Override
     public boolean isActive() {
-        return true; // TODO implement
+        return upstreamCanProduceTuples;
     }
 
     public AbstractDataset<Solution_> getParent() {

docs/src/modules/ROOT/pages/constraints-and-score/performance.adoc

@@ -93,9 +93,10 @@ the constraint may still be deactivated at runtime,
 if the engine can prove that it will never contribute to the score.
 For example, a constraint using `forEach(Visit.class)` will be deactivated
 if there are no `Visit` instances in the solution.
-This is inferior though to manually setting the constraint weight to zero,
+
+This is inferior to manually setting the constraint weight to zero,
 as the engine can only perform optimizations it can guarantee are safe
-based on the information it has.
+based on the limited information it has.
 With full understanding of the domain,
 you are in a much better position to know which constraints are relevant and which are not,
 and you can set the weights accordingly.