fix: validate the effective configuration

Author: rsynek

model/rest/src/main/java/ai/timefold/solver/model/rest/impl/AbstractModelAPIResource.java

@@ -656,12 +656,13 @@ public Multi<Metadata<Score_>> streamMetadata(
     @Produces(MediaType.APPLICATION_JSON)
     public ValidationResult<ValidationIssue_> getValidationResult(
             @Parameter(description = "Unique identifier of the schedule", required = true) @PathParam("id") String id) {
-        ValidationBuilder validationBuilder = new ValidationBuilder();
-        ModelRequest<ModelInput_, ModelConfigurationOverrides_> modelRequest = storageService.getModelRequest(id);
-        if (modelRequest.modelInput() == null) {
+        ModelInput_ modelInput = storageService.getModelInput(id);
+        var modelConfig = Configuration.getSafeModelConfig(storageService.getConfiguration(id));
+        if (modelInput == null) {
             throw new ItemNotFoundException(ErrorCodes.STORAGE_NO_JOB_FOUND, id);
         }
-        modelValidator.validate(validationBuilder, modelRequest.modelInput(), modelRequest.getModelConfig());
+        ValidationBuilder validationBuilder = new ValidationBuilder();
+        modelValidator.validate(validationBuilder, modelInput, modelConfig);
         return validationBuilder.build();
     }
 

model/worker/src/main/java/ai/timefold/solver/model/worker/impl/SolverWorker.java

@@ -40,7 +40,6 @@
 import ai.timefold.solver.model.definition.api.domain.Configuration;
 import ai.timefold.solver.model.definition.api.domain.Metadata;
 import ai.timefold.solver.model.definition.api.domain.ModelConfig;
-import ai.timefold.solver.model.definition.api.domain.ModelRequest;
 import ai.timefold.solver.model.definition.api.enrichment.SolverModelEnricherService;
 import ai.timefold.solver.model.definition.api.enrichment.SolverModelEnrichmentDirectorService;
 import ai.timefold.solver.model.definition.api.metrics.InputMetricsAware;
@@ -446,8 +445,8 @@ private LegacyValidationResult validateAndUpdateRun(String id) {
             return LegacyValidationResult.successful();
         }
 
-        ModelRequest modelRequest = storageService.getModelRequest(id);
-        if (modelRequest.modelInput() == null) {
+        ModelInput modelInput = storageService.getModelInput(id);
+        if (modelInput == null) {
             logUnreadableInput(id);
             /*
              * The only case of input being null is when it cannot be parsed, in which case the metadata already
@@ -456,8 +455,9 @@ private LegacyValidationResult validateAndUpdateRun(String id) {
             return storageService.getMetadata(id).getValidationResult();
         }
 
+        var modelConfig = Configuration.getSafeModelConfig(storageService.getConfiguration(id));
         ValidationBuilder validationBuilder = new ValidationBuilder();
-        modelValidator.validate(validationBuilder, modelRequest.modelInput(), modelRequest.getModelConfig());
+        modelValidator.validate(validationBuilder, modelInput, modelConfig);
 
         // We store both the new and old validation result format for backward compatibility.
         ValidationResult validationResponse = validationBuilder.build();