fix: clone the solution before sending it to the consumer#1583
Merged
Conversation
|
triceo
requested changes
May 19, 2025
triceo
left a comment
Collaborator
There was a problem hiding this comment.
We can still improve this a bit.
triceo
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR addresses an issue where we return the same solution instance as the SolverScope to external consumers. Therefore, if changes are made to the solution, it may be possible that these changes will affect the solver phases, because the current best solution from the solver scope is restored at the end of each phase.
It is worth noting that I have analyzed the use of
SolverScope::getBestSolutionand external actions. The solution is now cloned before being shared with these external consumers.