fix: Benchmarker best score graph no longer empty#1636
Merged
Conversation
triceo
had a problem deploying
to
documentation (preview)
GitHub Actions
Failure
triceo
had a problem deploying
to
documentation (preview)
GitHub Actions
Failure
triceo
had a problem deploying
to
documentation (preview)
GitHub Actions
Failure
triceo
had a problem deploying
to
documentation (preview)
GitHub Actions
Failure
triceo
requested review from
zepfred
and removed request for
Christopher-Chianelli
zepfred
reviewed
Jun 9, 2025
zepfred
reviewed
Jun 9, 2025
zepfred
reviewed
Jun 9, 2025
zepfred
reviewed
Jun 9, 2025
zepfred
reviewed
Jun 9, 2025
triceo
had a problem deploying
to
documentation (preview)
GitHub Actions
Failure
zepfred
approved these changes
Jun 9, 2025
zepfred
left a comment
zepfred
left a comment
Contributor
There was a problem hiding this comment.
I've confirmed that it works with some quick-start modules. There are a few minor comments, but overall, it looks great to me!
triceo
had a problem deploying
to
documentation (preview)
GitHub Actions
Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the init score removal (cf87aa7), we did not notice that this impacts metrics as well. Benchmarker reads its data from metrics, and therefore lost the information on what score is or is not initialized. As a result, the default value was always false, resulting in empty score graph.
This commit fixes that issue by registering a metric for the unassigned count, which will be reused by benchmarker to provide the correct initialization state.