Skip to content

chore: another attempt at fixing flaky tests #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triceo merged 2 commits into from
Jun 10, 2025
Merged

chore: another attempt at fixing flaky tests #1639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0672d1
chore: fix JUnit warnings on abstract test methods
triceo Jun 10, 2025
5a73dfe
chore: don't run solver integration tests in parallel
triceo Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions core/src/test/java/ai/timefold/solver/core/config/solver/EnvironmentModeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,9 @@
import ai.timefold.solver.core.testutil.PlannerTestUtils;

import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.parallel.Execution;
import org.junit.jupiter.api.parallel.ExecutionMode;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;

@Execution(ExecutionMode.CONCURRENT)
class EnvironmentModeTest {

private static final int NUMBER_OF_RANDOM_NUMBERS_GENERATED = 1000;
Expand Down
37 changes: 0 additions & 37 deletions ...ai/timefold/solver/core/impl/score/stream/collector/AbstractConstraintCollectorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,116 +8,79 @@
import ai.timefold.solver.core.impl.score.stream.collector.connected_ranges.ConnectedRangeTracker;
import ai.timefold.solver.core.impl.score.stream.collector.consecutive.ConsecutiveSetTree;

import org.junit.jupiter.api.Test;

/**
* Prescribes tests that must be implemented for every cardinality of a constraint collector.
*/
public abstract class AbstractConstraintCollectorsTest {

@Test
public abstract void count();

@Test
public abstract void countLong();

@Test
public abstract void countDistinct();

@Test
public abstract void countDistinctLong();

@Test
public abstract void sum();

@Test
public abstract void sumLong();

@Test
public abstract void sumBigDecimal();

@Test
public abstract void sumBigInteger();

@Test
public abstract void sumDuration();

@Test
public abstract void sumPeriod();

@Test
public abstract void minComparable();

@Test
public abstract void minNotComparable();

@Test
public abstract void maxComparable();

@Test
public abstract void maxNotComparable();

@Test
public abstract void average();

@Test
public abstract void averageLong();

@Test
public abstract void averageBigDecimal();

@Test
public abstract void averageBigInteger();

@Test
public abstract void averageDuration();

@Test
public abstract void toSet();

@Test
public abstract void toSortedSet();

@Test
public abstract void toList();

@Test
public abstract void toMap();

@Test
public abstract void toMapMerged();

@Test
public abstract void toSortedMap();

@Test
public abstract void toSortedMapMerged();

@Test
public abstract void conditionally();

@Test
public abstract void compose2();

@Test
public abstract void compose3();

@Test
public abstract void compose4();

@Test
public abstract void toConsecutiveSequences();

@Test
public abstract void consecutiveUsage();

@Test
public abstract void consecutiveUsageDynamic();

@Test
public abstract void loadBalance();

@Test
public abstract void collectAndThen();

protected static SequenceChain<Integer, Integer> buildSequenceChain(Integer... data) {
Expand Down
3 changes: 0 additions & 3 deletions ...ava/ai/timefold/solver/core/impl/solver/AllowsUnassignedValuesListVariableSolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,9 @@
import ai.timefold.solver.core.testdomain.list.unassignedvar.TestdataAllowsUnassignedValuesListValue;

import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.parallel.Execution;
import org.junit.jupiter.api.parallel.ExecutionMode;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;

@Execution(ExecutionMode.CONCURRENT)
class AllowsUnassignedValuesListVariableSolverTest {

@ParameterizedTest
Expand Down
8 changes: 0 additions & 8 deletions ...ava/ai/timefold/solver/core/impl/solver/termination/AbstractCompositeTerminationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,18 @@
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;

import org.junit.jupiter.api.Test;

abstract class AbstractCompositeTerminationTest {

@Test
abstract void solveTermination();

@Test
abstract void phaseTermination();

@Test
abstract void phaseTerminationInapplicable();

@Test
abstract void calculateSolverTimeGradientTest();

@Test
abstract void calculatePhaseTimeGradientTest();

@Test
abstract void calculatePhaseTimeGradientInapplicableTest();

protected static <Solution_> PhaseTermination<Solution_> mockPhaseTermination() {
Expand Down
Loading