perf: optimize the updater used for shadow variables in certain cases#1659
Merged
triceo merged 7 commits intoJun 26, 2025
Conversation
…an update can go - If only one entity has declarative variables, and all sources are either of the form "previous.*", "undirectional" or "declarative", then create a cascading updater using next to get successor and (index, id(entity)) for the initial sort. - If only one entity has declarative variables, and all sources are either of the form "next.*", "undirectional" or "declarative", then create a cascading updater using previous to get successor and (-index, id(entity)) for the initial sort. - If there are no dynamic edges, use a fixed topological order for each variable. - Otherwise use the current approach. Undirectional mean variables that don't create edges in the graph (such as accessing a fact on the inverse or genuine variables).
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Jun 24, 2025
triceo
left a comment
triceo
left a comment
Collaborator
There was a problem hiding this comment.
First round of review complete. In general, we need more comments/explainers.
I'll run the code through some benchmarks now, see what comes up.
triceo
reviewed
Jun 24, 2025
triceo
reviewed
Jun 24, 2025
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
approved these changes
Jun 26, 2025
…not instances of the declarative class
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Jun 26, 2025
triceo
reviewed
Jun 26, 2025
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Co-authored-by: Lukáš Petrovický <lukas@petrovicky.net>
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Christopher-Chianelli
deleted the
perf/happy-paths-declarative-shadow-variables
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undirectional mean variables that don't create edges in the graph (such as accessing a fact on the inverse or genuine variables).