chore: use Gizmo MemberAccessors when possible, remove domainAccessType from SolverConfig#2123
Merged
Merged
Conversation
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Feb 15, 2026
Collaborator
There was a problem hiding this comment.
IMO we have more work to do. Other than the notes inline, I think we should also:
- Add a note on the configuration disappearing to the Markdown TODO file in
docs/, so that I have a full list of things to mention in upgrade recipe later. - Check the documentation for the domain access type; I find it strange that this setting would never be mentioned, yet we're not updating the docs.
- Consider that maybe we only enable GIZMO for Enterprise? (Not sure if good idea, but it crossed my mind as I was reviewing the PR.)
Also, Sonar.
…pe from SolverConfig Note: SolutionCloner will still use REFLECTION by default, since GIZMO cannot copy final fields and requires all fields to be accessible (i.e. either public or have public getters and setters).
Christopher-Chianelli
force-pushed
the
feat/spring-gizmo
branch
from
d32b2ef to
ceaca30
Compare
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
force-pushed
the
feat/spring-gizmo
branch
from
0297dcf to
cbe5023
Compare
triceo
approved these changes
Feb 18, 2026
triceo
left a comment
triceo
left a comment
Collaborator
There was a problem hiding this comment.
I resolved the Sonar comments myself, in order to not block other PRs.
LGTM.
triceo
force-pushed
the
feat/spring-gizmo
branch
from
cbe5023 to
84ff78a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: SolutionCloner will still use REFLECTION by default, since GIZMO cannot copy final fields and requires all fields to be accessible (i.e. either public or have public getters and setters).
Partially completes #2110 (Did not remove
AutoDiscoverMemberTypeas that is unrelated to GIZMO).