Skip to content

Leftovers#2136

Merged
triceo merged 5 commits into
TimefoldAI:mainfrom
triceo:leftovers
Feb 24, 2026
Merged

Leftovers#2136
triceo merged 5 commits into
TimefoldAI:mainfrom
triceo:leftovers

Conversation

@triceo

@triceo triceo commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

The commits will not be squashed, they are too unrelated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR contains miscellaneous "leftover" changes that address various technical debt items and API modernizations. The changes are intentionally unrelated and will not be squashed, as noted in the PR description.

Changes:

  • Standardized locale format from underscore (cs_cz) to hyphen (cs-CZ) notation using Locale.forLanguageTag() and toLanguageTag()
  • Removed the ProblemId_ generic type parameter from SolverManager, SolverJob, SolverJobBuilder and related classes, simplifying the API to use Object for problem IDs
  • Updated Jackson API calls from deprecated methods (serializationInclusion(), getCurrentName(), fields()) to modern equivalents (defaultPropertyInclusion(), currentName(), properties())
  • Updated JUnit 5 API to add ParameterDeclarations parameter to ArgumentsProvider.provideArguments()
  • Modernized Gizmo API calls from objEquals() to exprEquals()
  • Modernized thread factory implementation using Java's Thread.ofPlatform() builder pattern
  • Added strict validation for constraint names and groups (alphanumeric, spaces, underscores, hyphens, apostrophes, dots only)
  • Migrated from @NonNull to @NullMarked with @Nullable for null safety annotations
  • Added no-args constructor to MutableReference class
  • Simplified compiler warnings configuration to -Xlint:none

Reviewed changes

Copilot reviewed 80 out of 80 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
locale XML/Java files Changed locale format from underscore to hyphen notation (cs_cz → cs-CZ)
SolverManager and related Removed ProblemId_ generic parameter, simplified to Object
Jackson integration Updated deprecated Jackson APIs to modern equivalents
TerminationTest.java Added ParameterDeclarations parameter for JUnit 5 compatibility
Thread factory Modernized using Thread.ofPlatform() builder
AbstractConstraintBuilder Added constraint name/group validation with tests
Build configuration Simplified compiler args to suppress all warnings
Gizmo classes Updated from objEquals to exprEquals
Null annotations Migrated to @NullMarked pattern throughout

Comment thread build/build-parent/pom.xml
Comment thread docs/TODO.md

@zepfred zepfred left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are questions about the best solution for consumer and Jackson object initialization. I will approve it after they are answered.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 84 out of 84 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 84 out of 84 changed files in this pull request and generated no new comments.

@zepfred zepfred left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud

Copy link
Copy Markdown

@triceo triceo merged commit 7c92839 into TimefoldAI:main Feb 24, 2026
30 of 44 checks passed
@triceo triceo deleted the leftovers branch February 24, 2026 12:38
@triceo triceo linked an issue Feb 26, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api: SolverManager should move from problemId to jobId.

3 participants