Leftovers#2136
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR contains miscellaneous "leftover" changes that address various technical debt items and API modernizations. The changes are intentionally unrelated and will not be squashed, as noted in the PR description.
Changes:
- Standardized locale format from underscore (
cs_cz) to hyphen (cs-CZ) notation usingLocale.forLanguageTag()andtoLanguageTag() - Removed the
ProblemId_generic type parameter fromSolverManager,SolverJob,SolverJobBuilderand related classes, simplifying the API to useObjectfor problem IDs - Updated Jackson API calls from deprecated methods (
serializationInclusion(),getCurrentName(),fields()) to modern equivalents (defaultPropertyInclusion(),currentName(),properties()) - Updated JUnit 5 API to add
ParameterDeclarationsparameter toArgumentsProvider.provideArguments() - Modernized Gizmo API calls from
objEquals()toexprEquals() - Modernized thread factory implementation using Java's
Thread.ofPlatform()builder pattern - Added strict validation for constraint names and groups (alphanumeric, spaces, underscores, hyphens, apostrophes, dots only)
- Migrated from
@NonNullto@NullMarkedwith@Nullablefor null safety annotations - Added no-args constructor to
MutableReferenceclass - Simplified compiler warnings configuration to
-Xlint:none
Reviewed changes
Copilot reviewed 80 out of 80 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| locale XML/Java files | Changed locale format from underscore to hyphen notation (cs_cz → cs-CZ) |
| SolverManager and related | Removed ProblemId_ generic parameter, simplified to Object |
| Jackson integration | Updated deprecated Jackson APIs to modern equivalents |
| TerminationTest.java | Added ParameterDeclarations parameter for JUnit 5 compatibility |
| Thread factory | Modernized using Thread.ofPlatform() builder |
| AbstractConstraintBuilder | Added constraint name/group validation with tests |
| Build configuration | Simplified compiler args to suppress all warnings |
| Gizmo classes | Updated from objEquals to exprEquals |
| Null annotations | Migrated to @NullMarked pattern throughout |
zepfred
reviewed
Feb 23, 2026
zepfred
reviewed
Feb 23, 2026
zepfred
reviewed
Feb 23, 2026
zepfred
reviewed
Feb 23, 2026
zepfred
reviewed
Feb 23, 2026
zepfred
reviewed
Feb 23, 2026
zepfred
reviewed
Feb 23, 2026
zepfred
reviewed
Feb 23, 2026
zepfred
left a comment
Contributor
There was a problem hiding this comment.
There are questions about the best solution for consumer and Jackson object initialization. I will approve it after they are answered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The commits will not be squashed, they are too unrelated.