fix: entities use equality comparison#2301
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the public API annotation Javadocs for solution collection properties to recommend Java 21’s SequencedCollection as the preferred way to guarantee deterministic iteration order (important for solver reproducibility).
Changes:
- Update Javadocs in collection property annotations to recommend
SequencedCollection(with examples such asListandLinkedHashSet). - Add
SequencedCollectionimports to support the new Javadoc links.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/main/java/ai/timefold/solver/core/api/domain/solution/ProblemFactCollectionProperty.java | Javadoc recommendation updated to SequencedCollection; imports adjusted (currently leaves an unused import). |
| core/src/main/java/ai/timefold/solver/core/api/domain/solution/PlanningEntityCollectionProperty.java | Same Javadoc update for entity collections; imports adjusted (currently leaves an unused import). |
triceo
changed the title
triceo
changed the title
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes identity comparisons from Constraint Streams, since that is a bug which we recently fixed for value ranges as well.
Also improves Javadoc around entities, facts and collections.
Downstream bug fix: TimefoldAI/timefold-quickstarts#1077 (review)