chore: merge model parents and disconnect it from build parent#2323
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the model build by removing the layered “base parent” POM, folding its responsibilities into model-parent, and decoupling model-parent from the solver build parent to avoid cross-build side effects, while also updating renamed Enterprise dependencies.
Changes:
- Removed the
model-base-parentmodule from the model reactor and deleted its POM. - Made
timefold-solver-model-parentstandalone (no parent), adding its own key version/properties and BOM imports. - Updated Enterprise profile dependency/artifactId renames and added Enterprise BOM import/repository wiring.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| model/pom.xml | Removes facade/model-base-parent from the module list to reflect the parent POM merge. |
| model/facade/model-parent/pom.xml | Converts the model parent into a standalone parent POM, adds version management/BOM imports, and updates Enterprise profile dependencies. |
| model/facade/model-base-parent/pom.xml | Deletes the now-obsolete base parent POM after consolidation. |
rsynek
force-pushed
the
fix/fix-model-parent
branch
from
94ffa78 to
0aac227
Compare
winklerm
left a comment
winklerm
left a comment
There was a problem hiding this comment.
Thanks, the changes look good to me!
I have left a question and one concern about the flatten plugin, which I find potentially problematic, but I do not have any proof that it will not work without it, so leaving that up to your judgment.
Most plugins should have been defined in pluginManagement only. Added the flatten-maven-plugin to make sure the revision property does not propagate from models.
rsynek
force-pushed
the
fix/fix-model-parent
branch
from
d2daa87 to
b4e27bb
Compare
winklerm
left a comment
winklerm
left a comment
There was a problem hiding this comment.
Thank you! One more question inline, otherwise looks good to me!
|
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
Small comment; LGTM when resolved.
| <!--suppress UnresolvedMavenProperty --> | ||
| <ai.timefold.platform.model.test.api-key>${env.TF_PLATFORM_TEST_API_KEY}</ai.timefold.platform.model.test.api-key> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> |
Notable changes:
model-base-parentandmodel-parentas the idea of layered models is no longer relevantmodel-parentfrombuild-parentto avoid solver build process impact modelsenterpriseprofile