feat: Add sliding window and minimum improvement ratio to termination confiig#2324
Conversation
|
I really dislike the fact that we're opening up these configuration options and I would like to have one last change to prevent that. |
Yes, it's better to talk with @oemebamo, as this feature comes from a product request (https://github.com/TimefoldAI/timefold-platform/issues/4439). |
|
Discussed with Jurriaan, feature stays, I go away. |
rsynek
left a comment
There was a problem hiding this comment.
Thanks @diogodanielsoaresferreira !
I left a couple of comments inline. Plus, there are no tests. At least, we should check if we create the expected Solver TerminationConfig.
|
The failure on windows-latest is a flaky test. Rerunning. |
Added some unit tests to TerminationService and SolverTerminationConfig. |
|



No description provided.