Skip to content

feat: Add sliding window and minimum improvement ratio to termination confiig#2324

Merged
rsynek merged 6 commits into
TimefoldAI:mainfrom
diogodanielsoaresferreira:feat/configure_diminshing_return_variables
Jun 4, 2026
Merged

feat: Add sliding window and minimum improvement ratio to termination confiig#2324
rsynek merged 6 commits into
TimefoldAI:mainfrom
diogodanielsoaresferreira:feat/configure_diminshing_return_variables

Conversation

@diogodanielsoaresferreira

Copy link
Copy Markdown
Contributor

No description provided.

@triceo

triceo commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

I really dislike the fact that we're opening up these configuration options and I would like to have one last change to prevent that.
Is there any product requirement for this work, should I talk to Jurriaan?

@diogodanielsoaresferreira

Copy link
Copy Markdown
Contributor Author

I really dislike the fact that we're opening up these configuration options and I would like to have one last change to prevent that. Is there any product requirement for this work, should I talk to Jurriaan?

Yes, it's better to talk with @oemebamo, as this feature comes from a product request (https://github.com/TimefoldAI/timefold-platform/issues/4439).

@triceo

triceo commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Discussed with Jurriaan, feature stays, I go away.

@rsynek rsynek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diogodanielsoaresferreira !

I left a couple of comments inline. Plus, there are no tests. At least, we should check if we create the expected Solver TerminationConfig.

Comment thread model/model-defaults/src/main/resources/application.properties Outdated
@rsynek

rsynek commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

The failure on windows-latest is a flaky test. Rerunning.

@diogodanielsoaresferreira

Copy link
Copy Markdown
Contributor Author

Thanks @diogodanielsoaresferreira !

I left a couple of comments inline. Plus, there are no tests. At least, we should check if we create the expected Solver TerminationConfig.

Added some unit tests to TerminationService and SolverTerminationConfig.

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@rsynek rsynek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@rsynek rsynek merged commit 7542a7f into TimefoldAI:main Jun 4, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants