fix(constraint-streams): fact-based precompute() correctly propagates#2338
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes precompute propagation so that output tuples derived purely from problem facts are emitted downstream and properly retracted when the precompute cache is invalidated (for example, after problem fact removal).
Changes:
- Add tracking and replay for fact-only output tuples in
RecordAndReplayPropagator, including proper retraction on cache invalidation. - Extend the precompute test suite with a regression test that removes a problem fact and verifies the corresponding tuple is retracted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/src/main/java/ai/timefold/solver/core/impl/bavet/common/RecordAndReplayPropagator.java | Ensures fact-derived output tuples are recorded once, inserted downstream, and later retractable on cache invalidation. |
| core/src/test/java/ai/timefold/solver/core/impl/score/stream/common/uni/AbstractUniConstraintStreamPrecomputeTest.java | Adds a regression test covering precompute(forEachUnfiltered(factClass)) behavior across problem fact removal. |
|
Christopher-Chianelli
approved these changes
Jun 8, 2026
triceo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified and fixed by Claude as a side effect of doing something else.
If you have a better idea of fixing this, be my guest.