Skip to content

ci: remove 1.x release workflow#2351

Merged
triceo merged 2 commits into
TimefoldAI:1.xfrom
zepfred:chore/update-release-1-x
Jun 12, 2026
Merged

ci: remove 1.x release workflow#2351
triceo merged 2 commits into
TimefoldAI:1.xfrom
zepfred:chore/update-release-1-x

Conversation

@zepfred

@zepfred zepfred commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 10, 2026 11:43
@zepfred zepfred requested a review from triceo as a code owner June 10, 2026 11:43
@zepfred zepfred requested a review from rsynek June 10, 2026 11:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release-1.x GitHub Actions workflow to improve dispatch UX and add early input validation for community 1.x releases published to Maven Central.

Changes:

  • Renamed the workflow for clearer intent (“Release Community 1.x to Maven Central”).
  • Made dryRun a typed boolean input and simplified its description.
  • Added steps to log workflow inputs and validate the provided release version; also removed unused pull-requests: write permission.
Comments suppressed due to low confidence (1)

.github/workflows/release-1.x.yml:50

  • The version validation only checks that the input starts with 1., which still allows shell metacharacters (e.g. 1.0.0$(...)) that could get interpreted later when the version is embedded into shell commands on a self-hosted runner.

@zepfred zepfred force-pushed the chore/update-release-1-x branch from dcc9c14 to f3e49cc Compare June 10, 2026 11:54
@zepfred zepfred changed the title chore: update release workflow chore: update release 1.x workflow Jun 10, 2026
@zepfred zepfred changed the title chore: update release 1.x workflow chore: update 1.x release workflow Jun 10, 2026
Copilot AI review requested due to automatic review settings June 10, 2026 11:58
@zepfred zepfred force-pushed the chore/update-release-1-x branch from f3e49cc to 7173c52 Compare June 10, 2026 11:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/release-1.x.yml:83

  • Unquoted $DRY_RUN allows word-splitting and could inadvertently pass extra Maven arguments if the workflow input contains whitespace; quote it to ensure it is treated as a single boolean value.

@rsynek

rsynek commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

I am a bit confused. Why do we have a 1.x release workflow on both the main branch and the 1.x branch?

I understand we have to have it on the main branch as otherwise, it won't show up in the UI. Why do we need it on 1.x?

@rsynek

rsynek commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

@zepfred since the 1.x release will be only ever started from the main branch, the 1.x workflow is effectively a dead code. Can we rather remove it?

@triceo triceo changed the title chore: update 1.x release workflow ci: remove 1.x release workflow Jun 12, 2026
@triceo triceo merged commit 012431b into TimefoldAI:1.x Jun 12, 2026
13 of 14 checks passed
@zepfred

zepfred commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

We cannot delete it from the 1.x branch, or we will not be able to trigger it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants