Stabilize submitMoreProblemsThanCpus_allGetSolved by removing host-CPU dependence#2367
Draft
Copilot wants to merge 2 commits into
Draft
Stabilize submitMoreProblemsThanCpus_allGetSolved by removing host-CPU dependence#2367Copilot wants to merge 2 commits into
submitMoreProblemsThanCpus_allGetSolved by removing host-CPU dependence#2367Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix flakiness in SolverManagerTest.submitMoreProblemsThanCpus_allGetSolved
Stabilize Jun 12, 2026
submitMoreProblemsThanCpus_allGetSolved by removing host-CPU dependence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SolverManagerTest.submitMoreProblemsThanCpus_allGetSolved()was flaky because its load was derived fromRuntime.availableProcessors(), making timing and scheduling behavior host-dependent. This could intermittently stall onjob.getFinalBestSolution()under high iteration counts.Deterministic oversubscription setup
parallelSolverCount(2) for this test path.problemCountfrom that value (parallelSolverCount * 2) so the test still guarantees “more jobs than solver threads”.Targeted helper update
createSolverManagerTestableByDifferentConsumers()to acceptparallelSolverCount.SolverManagerwithSolverManagerConfig.withParallelSolverCount(...)for this test scenario.