Skip to content

Stabilize submitMoreProblemsThanCpus_allGetSolved while preserving CPU-oversubscription invariant #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+7 −5
Closed

Stabilize submitMoreProblemsThanCpus_allGetSolved while preserving CPU-oversubscription invariant #2367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7394c66
Initial plan
Copilot Jun 12, 2026
a9c05f9
Stabilize submitMoreProblemsThanCpus SolverManager test
Copilot Jun 12, 2026
0bdd24a
Preserve CPU oversubscription invariant in SolverManager test
Copilot Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions core/src/test/java/ai/timefold/solver/core/api/solver/SolverManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,16 +1014,17 @@ private void assertInitializedJobs(List<SolverJob<TestdataSolution>> jobs)
@Test
@Timeout(60)
void submitMoreProblemsThanCpus_allGetSolved() throws InterruptedException, ExecutionException {
// Use twice the amount of problems than available processors.
var problemCount = Runtime.getRuntime().availableProcessors() * 2;
try (var solverManager = createSolverManagerTestableByDifferentConsumers()) {
var parallelSolverCount = 2;
// Keep the test invariant: submit more jobs than CPUs.
var problemCount = Math.max(parallelSolverCount * 2, Runtime.getRuntime().availableProcessors() + 1);
try (var solverManager = createSolverManagerTestableByDifferentConsumers(parallelSolverCount)) {
assertSolveWithoutConsumer(problemCount, solverManager);
assertSolveWithConsumer(problemCount, solverManager, true);
assertSolveWithConsumer(problemCount, solverManager, false);
}
}

private SolverManager<TestdataSolution> createSolverManagerTestableByDifferentConsumers() {
private SolverManager<TestdataSolution> createSolverManagerTestableByDifferentConsumers(int parallelSolverCount) {
var solverConfig = PlannerTestUtils.buildSolverConfig(TestdataSolution.class, TestdataEntity.class)
.withPhases(IntStream.of(0, 1)
.mapToObj(x -> new CustomPhaseConfig().withCustomPhaseCommands(
Expand All @@ -1037,7 +1038,8 @@ private SolverManager<TestdataSolution> createSolverManagerTestableByDifferentCo
context.executeAndCalculateScore(move);
}))
.toArray(PhaseConfig[]::new));
return createDefaultSolverManager(solverConfig);
return createSolverManager(solverConfig,
new SolverManagerConfig().withParallelSolverCount(Integer.toString(parallelSolverCount)));
}

private void assertSolveWithoutConsumer(int problemCount, SolverManager<TestdataSolution> solverManager)
Expand Down
Loading