chore: small refactors#2368
Draft
triceo wants to merge 3 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small internal refactors in the core implementation code, primarily tightening constructors on an internal utility and modernizing list access using Java 21 APIs (aligning with the “enterprise counterpart” requirement mentioned in the PR description).
Changes:
- Narrowed
DynamicIntArray’s no-arg constructor visibility and removed a redundant constructor overload. - Replaced
list.get(0)withlist.getFirst()inDefaultVariableReferenceGraphfor clearer intent on sequenced lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/src/main/java/ai/timefold/solver/core/impl/util/DynamicIntArray.java | Reduces public constructor surface area and performs minor Javadoc cleanup. |
| core/src/main/java/ai/timefold/solver/core/impl/domain/variable/declarative/DefaultVariableReferenceGraph.java | Uses Java 21 List#getFirst() for clearer “first element” access semantics. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for the enterprise counterpart.