Skip to content

fix: semaphore release submitted to a dead executor #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triceo merged 2 commits into from
Jun 16, 2026
+4 −5
Merged

fix: semaphore release submitted to a dead executor #2374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c3f66
fix: semaphore release submitted to a dead executor
triceo Jun 15, 2026
6e6bcf9
Potential fix for pull request finding
triceo Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions core/src/main/java/ai/timefold/solver/core/impl/solver/ConsumerSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ private void tryConsumeWaitingIntermediateBestSolution() {
}
if (activeConsumption.tryAcquire()) {
scheduleIntermediateBestSolutionConsumption()
.whenCompleteAsync((solution, throwable) -> {
.whenComplete((unused, throwable) -> {
activeConsumption.release();
tryConsumeWaitingIntermediateBestSolution();
}, consumerExecutor);
});
Comment thread
triceo marked this conversation as resolved.
}
}

Expand Down Expand Up @@ -120,7 +120,7 @@ void consumeFirstInitializedSolution(Solution_ solution, EventProducerId produce
this.firstInitializedSolution.getAndSet(solution); // Reachable more than once; problem change triggers restart.
scheduleFirstInitializedSolutionConsumption(s -> firstInitializedSolutionConsumer
.accept(new FirstInitializedSolutionEventImpl<>(s, producerId, isTerminatedEarly)))
.whenCompleteAsync((unused, throwable) -> firstSolutionConsumption.release(), consumerExecutor);
.whenComplete((unused, throwable) -> firstSolutionConsumption.release());
}

private CompletableFuture<Void> scheduleFirstInitializedSolutionConsumption(Consumer<? super Solution_> solutionConsumer) {
Expand Down Expand Up @@ -153,8 +153,7 @@ void consumeStartSolverJob(Solution_ solution) {
throw new IllegalStateException("Interrupted when waiting for the start solver job consumption.");
}
this.initialSolution.getAndSet(solution); // Reachable more than once; problem change triggers restart.
scheduleStartJobConsumption().whenCompleteAsync((unused, throwable) -> startSolverJobConsumption.release(),
consumerExecutor);
scheduleStartJobConsumption().whenComplete((unused, throwable) -> startSolverJobConsumption.release());
Comment thread
triceo marked this conversation as resolved.
}

private CompletableFuture<Void> scheduleStartJobConsumption() {
Expand Down
Loading