Skip to content

fix: remove the resolvedMapLocation from API#2378

Closed
rsynek wants to merge 1 commit into
TimefoldAI:mainfrom
rsynek:fix/remove-resolved-location-from-api
Closed

fix: remove the resolvedMapLocation from API#2378
rsynek wants to merge 1 commit into
TimefoldAI:mainfrom
rsynek:fix/remove-resolved-location-from-api

Conversation

@rsynek

@rsynek rsynek commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

The resolvedMapLocation leaked into the API, where it does not belog.

Comment on lines +73 to 74
@Schema(hidden = true)
@JsonInclude(JsonInclude.Include.NON_EMPTY)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a partial hotfix, since for routing models, the field will be non-empty and thus it will be sent in the JSON payload to the client side.

Doing the full split means handling this in the REST API, both in the solver-service and the platform.

Another option is reverting the original change.

@mswiderski mswiderski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with this as quick fix to make sure this is not "advertised" via open api and then be refactored down the line.

@diogodanielsoaresferreira

Copy link
Copy Markdown
Contributor

I am ok with hiding it or removing it completely for now, as this is not an urgent feature.

@sonarqubecloud

Copy link
Copy Markdown

@rsynek

rsynek commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

@rsynek rsynek closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants