Skip to content

fix: remove the resolvedMapLocation from API #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsynek wants to merge 1 commit into from
+15 −2
Closed

fix: remove the resolvedMapLocation from API #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...e/definition/src/main/java/ai/timefold/solver/service/definition/api/domain/Metadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ public final class Metadata<Score_> implements Status<Score_> {
@JsonInclude(JsonInclude.Include.NON_EMPTY)
private String failureMessage;

@Schema(nullable = true,
description = "The map-service region resolved when location is auto-select.")
@Schema(hidden = true)
@JsonInclude(JsonInclude.Include.NON_EMPTY)
Comment on lines +73 to 74

@rsynek rsynek Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a partial hotfix, since for routing models, the field will be non-empty and thus it will be sent in the JSON payload to the client side.

Doing the full split means handling this in the REST API, both in the solver-service and the platform.

Another option is reverting the original change.

private String resolvedMapLocation;

Expand Down
14 changes: 14 additions & 0 deletions service/test-model/src/build/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2243,6 +2243,20 @@
"description" : "Maximum solver step count. The solver will stop solving after a pre-determined amount of steps. Use when you require results independently of the hardware resources performance. Use this termination if you want to benchmark your models, not recommended for production use. If set, unimprovedSpentLimit must be empty. Warning: using this option will disable the default diminished returns termination which is recommended for most use cases.",
"type" : "integer",
"example" : 1000
},
"slidingWindowDuration" : {
"description" : "Sliding window (ISO 8601 duration format) over which score improvement is measured by the diminished returns termination. Defaults to PT30S when omitted. Only takes effect when diminished returns is active (i.e. unimprovedSpentLimit and stepCountLimit are both empty).",
"type" : "string",
"allOf" : [ {
"$ref" : "#/components/schemas/Duration"
} ],
"example" : "PT30S"
},
"minimumImprovementRatio" : {
"format" : "double",
"description" : "Minimum ratio between current and initial improvement before the diminished returns termination kicks in. Must be strictly positive. Defaults to 0.0001 when omitted. Only takes effect when diminished returns is active (i.e. unimprovedSpentLimit and stepCountLimit are both empty).",
"type" : "number",
"example" : 0.0001
}
},
"additionalProperties" : false
Expand Down
Loading