fix: Revert "feat: Add effective map location to metadata events (#2321)"#2380
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts commit 71f89e11, removing the previously added “resolved map-service location” propagation through maps-service responses into dataset Metadata and related insight/event flows.
Changes:
- Removes
resolvedMapLocationfromMetadataand deletes theMapEnrichmentContextside-channel used to propagate it to the worker. - Removes the
X-TF-MAPS-LOCATIONresponse header and related env var constants, and simplifies maps-service client caching structures accordingly. - Reverts/adjusts maps-service wiremock test transformers and client tests to no longer emit/assert the removed location metadata.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| service/worker/src/main/java/ai/timefold/solver/service/worker/impl/SolverWorker.java | Removes map-location side-channel injection and metadata write-back. |
| service/maps/service-test/src/main/java/ai/timefold/solver/service/maps/service/test/impl/HaversineDistanceResponseTransformer.java | Stops emitting the removed maps location header in wiremock responses. |
| service/maps/service-test/src/main/java/ai/timefold/solver/service/maps/service/test/impl/DistanceGetUpdateResponseTransformer.java | Reverts update-response simulation back to always returning 410 (no update path). |
| service/maps/service-integration/src/main/java/ai/timefold/solver/service/maps/service/integration/internal/provider/TravelTimeAndDistanceMatrixResponse.java | Drops the resolvedMapLocation field from the response record. |
| service/maps/service-integration/src/main/java/ai/timefold/solver/service/maps/service/integration/internal/model/TravelTimeAndDistanceWithMetadata.java | Drops the resolvedMapLocation field from the metadata wrapper record. |
| service/maps/service-client/src/test/java/ai/timefold/solver/service/maps/service/client/api/TravelTimeMatrixEnricherTest.java | Removes assertions/tests related to resolved map location propagation. |
| service/maps/service-client/src/main/java/ai/timefold/solver/service/maps/service/client/impl/MapServiceClientImpl.java | Removes reading/storing of the location header and trims cache item contents. |
| service/maps/service-client/src/main/java/ai/timefold/solver/service/maps/service/client/impl/CacheItem.java | Removes cached resolvedMapLocation from the cache record. |
| service/maps/service-client/src/main/java/ai/timefold/solver/service/maps/service/client/api/TravelTimeMatrixEnricher.java | Removes publishing of resolved map location into the side-channel context. |
| service/definition/src/main/java/ai/timefold/solver/service/definition/internal/platform/EnvironmentVars.java | Removes map-service location env var constants. |
| service/definition/src/main/java/ai/timefold/solver/service/definition/internal/MapEnrichmentContext.java | Deletes the map-location propagation context bean. |
| service/definition/src/main/java/ai/timefold/solver/service/definition/internal/Headers.java | Removes the X-TF-MAPS-LOCATION header constant. |
| service/definition/src/main/java/ai/timefold/solver/service/definition/api/domain/Metadata.java | Removes resolvedMapLocation field and its accessors/copying. |
…efoldAI#2321)" This reverts commit 71f89e1
rsynek
force-pushed
the
fix/revert-resolved-location
branch
from
036e90c to
f388412
Compare
diogodanielsoaresferreira
approved these changes
Jun 17, 2026
rsynek
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 71f89e1