chore: fail fast on custom phase if it returns an inconsistent solution - #2445
Merged
triceo merged 1 commit intoAug 2, 2026
Conversation
Christopher-Chianelli
force-pushed
the
chore/custom-phase-inconsistent-fail-fast
branch
from
June 30, 2026 10:06
c0859c2 to
4d2d222
Compare
Christopher-Chianelli
force-pushed
the
no-loops
branch
from
July 31, 2026 05:49
99d6a98 to
62bcf7e
Compare
Christopher-Chianelli
force-pushed
the
chore/custom-phase-inconsistent-fail-fast
branch
from
July 31, 2026 11:47
4d2d222 to
7fa3bf9
Compare
Christopher-Chianelli
marked this pull request as ready for review
July 31, 2026 11:49
Christopher-Chianelli
force-pushed
the
no-loops
branch
from
July 31, 2026 12:00
98fd71a to
cd4ddd8
Compare
Christopher-Chianelli
force-pushed
the
chore/custom-phase-inconsistent-fail-fast
branch
from
July 31, 2026 12:01
7fa3bf9 to
b39544f
Compare
triceo
approved these changes
Aug 2, 2026
triceo
left a comment
triceo
left a comment
Collaborator
There was a problem hiding this comment.
We'll refactor the invalid score detection, but not in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2444