-
Notifications
You must be signed in to change notification settings - Fork 219
chore: add indictment support to Bavet's Node Network #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Christopher-Chianelli
wants to merge
19
commits into
TimefoldAI:main
Choose a base branch
from
Christopher-Chianelli:feat/729
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
43bbfa8
feat: add plumbing for indictment support
Christopher-Chianelli bcb713c
chore: remove creating a new tuple for `ifExists` indictments
Christopher-Chianelli f527b5c
chore: use a Map to store extra indicted objects from ifExists
Christopher-Chianelli 8e5142d
chore: make UniConstraintStream tests aware of indictments
Christopher-Chianelli a9de626
fix: remove old indicted objects from original group in GroupNode
Christopher-Chianelli 6138f48
chore: move indictment code for IfExists to IndictmentSource
Christopher-Chianelli b060a21
chore: track support in indictment, not tuple
Christopher-Chianelli 029339f
chore: make getIndictedObjects() return null when indictments disable…
Christopher-Chianelli b560148
test: add tests for BiConstraintStream indictments
Christopher-Chianelli b71f8c5
test: make TriConstraintStream tests indictment aware
Christopher-Chianelli 178d0ee
test: Make BavetQuadConstraintStreamTest aware of indictments
Christopher-Chianelli ac14dcb
test: make AdvanceGroupByTest aware of indictments
Christopher-Chianelli dd0ec33
test: make BavetRegressionTest aware of indictments
Christopher-Chianelli bdb874a
fix: Propagate updates to indictments in ifExists even if left side d…
Christopher-Chianelli 07d6cb8
fix: update left indicted set even if its key not changed for indexed…
Christopher-Chianelli 5ec855d
test: make TriPrecompute test indictment aware
Christopher-Chianelli 62af614
test: make QuadPrecompute tests indictment aware
Christopher-Chianelli 9ea9561
chore: merge fixes
Christopher-Chianelli 0b67bca
chore: review comments
Christopher-Chianelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.