chore: more specific problem scale - #2549
Conversation
GitHub Actions
Inactive
GitHub Actions
Inactive
| @@ -17,8 +18,10 @@ | |||
| */ | |||
| @NullMarked | |||
| public record ProblemSizeStatistics(long entityCount, | |||
There was a problem hiding this comment.
Seeing as this is a public API, we should add a backwards-compatible constructor, and deprecate it.
Maybe even a migration script, this one will be easy.
| // Should we include immovable entities for the count? | ||
| // Problem scale ignores them. |
There was a problem hiding this comment.
That's a good question.
IMO we should include them in entity count, but they cannot affect the problem scale, so they don't.
Maybe we log that the entity count includes immovable as well? Not sure. We should definitely log not just "entity count" but "genuine entity count".
| var genuineEntityClassCountEntries = problemSizeStatistics.genuineEntityClassToEntityCount().entrySet(); | ||
| for (var genuineEntityCountEntry : genuineEntityClassCountEntries) { | ||
| var geninueEntityClass = genuineEntityCountEntry.getKey(); | ||
| logger.debug(" Entity ({}) count: {}", |
| .genuineEntityClassToVariableToValueCount() | ||
| .get(geninueEntityClass).entrySet()) { | ||
| var genuineVariable = geninueVariableEntry.getKey(); | ||
| logger.debug(" Variable ({}) estimated value count: {}", |
There was a problem hiding this comment.
Maybe we also want to show the variable's value type? Not sure.
I would certainly mention if basic/list.
|
2 participants
No description provided.