test: add tests for artifacts file

Author: Taxrosdev

src/artifacts.rs

@@ -30,7 +30,6 @@ pub fn get_artifact(artifact_name: &String, artifacts_file_path: &Path) -> Optio
         .map(|artifact| artifact.1.clone())
 }
 
-#[cfg(feature = "encoding")]
 pub fn add_artifact(artifact_name: String, manifest_hash: String, artifacts_file_path: &Path) {
     let mut artifacts: Vec<(String, String)> = read_artifacts_file(&artifacts_file_path)
         .iter()
@@ -44,7 +43,6 @@ pub fn add_artifact(artifact_name: String, manifest_hash: String, artifacts_file
         .expect("Couldn't write artifacts file");
 }
 
-#[cfg(feature = "encoding")]
 fn serialize_artifacts(artifacts: Vec<(String, String)>) -> String {
     let mut string = String::new();
 
@@ -54,3 +52,95 @@ fn serialize_artifacts(artifacts: Vec<(String, String)>) -> String {
 
     string
 }
+
+#[cfg(test)]
+mod tests {
+    use std::env::temp_dir;
+
+    use super::*;
+
+    #[test]
+    fn simple_all() {
+        let artifacts = vec![
+            ("test1".to_string(), 1.to_string()),
+            ("test2".to_string(), 2.to_string()),
+            ("test3".to_string(), 3.to_string()),
+        ];
+
+        let artifact_file_path = temp_dir().join("LCAS_test_artifact_simple_all.test");
+
+        for (artifact_name, manifest_hash) in &artifacts {
+            add_artifact(
+                artifact_name.to_string(),
+                manifest_hash.to_string(),
+                &artifact_file_path,
+            );
+        }
+
+        assert_eq!(&read_artifacts_file(&artifact_file_path), &artifacts);
+
+        assert_eq!(
+            get_artifact(&"test1".to_string(), &artifact_file_path).unwrap(),
+            1.to_string()
+        );
+    }
+
+    #[test]
+    fn get_artifact_not_found() {
+        let artifact_file_path = temp_dir().join("LCAS_test_artifact_not_found.test");
+        // Ensure file is empty
+        fs::write(&artifact_file_path, "").unwrap();
+        assert_eq!(
+            get_artifact(&"nonexistent".to_string(), &artifact_file_path),
+            None
+        );
+    }
+
+    #[test]
+    fn add_artifact_overwrites_existing() {
+        let artifact_file_path = temp_dir().join("LCAS_test_artifact_overwrite.test");
+        add_artifact(
+            "artifact".to_string(),
+            "hash1".to_string(),
+            &artifact_file_path,
+        );
+        add_artifact(
+            "artifact".to_string(),
+            "hash2".to_string(),
+            &artifact_file_path,
+        );
+        let artifacts = read_artifacts_file(&artifact_file_path);
+        assert_eq!(artifacts.len(), 1);
+        assert_eq!(artifacts[0], ("artifact".to_string(), "hash2".to_string()));
+    }
+
+    #[test]
+    fn read_artifacts_file_nonexistent() {
+        let artifact_file_path = temp_dir().join("LCAS_test_artifact_nonexistent.test");
+        // Ensure file does not exist
+        let _ = fs::remove_file(&artifact_file_path);
+        let artifacts = read_artifacts_file(&artifact_file_path);
+        assert!(artifacts.is_empty());
+    }
+
+    #[test]
+    #[should_panic(expected = "Malformed artifacts file")]
+    fn read_artifacts_file_malformed() {
+        let artifact_file_path = temp_dir().join("LCAS_test_artifact_malformed.test");
+        fs::write(&artifact_file_path, "bad_line_without_colon\n").unwrap();
+        let _ = read_artifacts_file(&artifact_file_path);
+    }
+
+    #[test]
+    fn simple_serialize_artifacts() {
+        let artifacts = vec![
+            ("test1".to_string(), 1.to_string()),
+            ("test2".to_string(), 2.to_string()),
+            ("test3".to_string(), 3.to_string()),
+        ];
+        assert_eq!(
+            serialize_artifacts(artifacts),
+            "test1:1\ntest2:2\ntest3:3\n"
+        )
+    }
+}

src/hash.rs

@@ -24,7 +24,7 @@ mod tests {
     use super::*;
 
     #[test]
-    fn it_works() {
+    fn hash_stable() {
         let result = hash(&vec![1, 2, 3]);
         assert_eq!(result, "16991689376074199867");
     }