Skip to content

Commit 349fda0

Browse files
committed
Fixed more github action issues
1 parent e3143d9 commit 349fda0

2 files changed

Lines changed: 16 additions & 5 deletions

File tree

.github/workflows/benchmark.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,18 @@ jobs:
6666
--output benchmarks/results/latest.json \
6767
-v
6868
69+
- name: Check if results were produced
70+
id: check_results
71+
run: |
72+
if [ -f benchmarks/results/latest.json ]; then
73+
echo "has_results=true" >> "$GITHUB_OUTPUT"
74+
else
75+
echo "::warning::No benchmark results produced (dataset download may have failed)"
76+
echo "has_results=false" >> "$GITHUB_OUTPUT"
77+
fi
78+
6979
- name: Convert results for github-action-benchmark
80+
if: steps.check_results.outputs.has_results == 'true'
7081
run: |
7182
python -c "
7283
import json
@@ -90,7 +101,7 @@ jobs:
90101
"
91102
92103
- name: Store benchmark result
93-
if: github.ref == 'refs/heads/main'
104+
if: github.ref == 'refs/heads/main' && steps.check_results.outputs.has_results == 'true'
94105
uses: benchmark-action/github-action-benchmark@v1
95106
with:
96107
tool: 'customBiggerIsBetter'
@@ -104,7 +115,7 @@ jobs:
104115
fail-on-alert: false
105116

106117
- name: Compare with baseline (PRs only)
107-
if: github.event_name == 'pull_request'
118+
if: github.event_name == 'pull_request' && steps.check_results.outputs.has_results == 'true'
108119
uses: benchmark-action/github-action-benchmark@v1
109120
with:
110121
tool: 'customBiggerIsBetter'
@@ -118,6 +129,7 @@ jobs:
118129
fail-on-alert: true
119130

120131
- name: Upload results artifact
132+
if: steps.check_results.outputs.has_results == 'true'
121133
uses: actions/upload-artifact@v4
122134
with:
123135
name: benchmark-results

pyproject.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ classifiers = [
5757
requires-python = ">=3.9"
5858
dependencies = [
5959
"numpy>=1.19.0",
60-
"seaborn>=0.13.2",
6160
]
6261

6362
[project.scripts]
@@ -68,8 +67,8 @@ kalign-py = "kalign.cli:main"
6867
biopython = ["biopython>=1.85"]
6968
skbio = ["scikit-bio>=0.6.3"]
7069
io = ["biopython>=1.85"] # For I/O helper functions
71-
analysis = ["pandas>=2.3.0", "matplotlib>=3.9.4"]
72-
all = ["biopython>=1.85", "scikit-bio>=0.6.3", "pandas>=2.3.0", "matplotlib>=3.9.4"]
70+
analysis = ["pandas>=2.3.0", "matplotlib>=3.9.4", "seaborn>=0.13.2"]
71+
all = ["biopython>=1.85", "scikit-bio>=0.6.3", "pandas>=2.3.0", "matplotlib>=3.9.4", "seaborn>=0.13.2"]
7372
benchmark = ["dash>=2.14", "plotly>=5.18", "pandas>=2.0", "tqdm>=4.60"]
7473

7574
# Development dependencies

0 commit comments

Comments
 (0)