Block conflicting MirrorPeer pairs before topology Pair cluster action - #1
Draft
TimothyAsirJeyasing wants to merge 1 commit into
Draft
Block conflicting MirrorPeer pairs before topology Pair cluster action#1TimothyAsirJeyasing wants to merge 1 commit into
TimothyAsirJeyasing wants to merge 1 commit into
Conversation
Extract verifyMirrorPeerExistence and related checks into a shared cluster-peering-validators utility used by both the Create DRPolicy form and the topology Pair cluster flow. The topology context menu now disables targets that would conflict with an existing MirrorPeer or sync DRPolicy, and opening the pair modal is blocked with the same error message shown during DR policy creation. Reuse of an existing identical pair remains allowed. Co-authored-by: Timothy <tjeyasin@redhat.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the 4.23 gap where
verifyMirrorPeerExistenceonly ran during Create DRPolicy form validation, not before the topology Pair cluster action.verifyMirrorPeerExistence,checkSyncPolicyExists, andhasConflictingPeeringinto a shared utility (cluster-peering-validators.ts) used by both the Create DRPolicy wizard and topology.Behavior
Testing
cluster-peering-validators.spec.ts(8 cases, all passing)Not in scope
MCO backend create-time validation for CLI/API bypass remains unchanged (optional hardening for a follow-up).