Fixes for version command in query service (#318)

* Fixes for version command in query service

This can lead to errors in some use cases

* readme

Author: tinder-maxwellelliott

MODULE.bazel

@@ -1,6 +1,6 @@
 module(
     name = "bazel-diff",
-    version = "17.0.3",
+    version = "17.1.0",
     compatibility_level = 0,
 )
 

MODULE.bazel.lock

@@ -341,7 +341,7 @@ First, add the following snippet to your project:
 #### Bzlmod snippet
 
 ```bazel
-bazel_dep(name = "bazel-diff", version = "15.0.5")
+bazel_dep(name = "bazel-diff", version = "17.1.0")
 ```
 
 You can now run the tool with:

README.md

@@ -30,7 +30,7 @@ class BazelQueryService(
 
   @OptIn(ExperimentalCoroutinesApi::class)
   private suspend fun determineBazelVersion(): Triple<Int, Int, Int> {
-    val cmd = arrayOf(bazelPath.toString(), "--version")
+    val cmd = arrayOf(bazelPath.toString(), "version")
     logger.i { "Executing Bazel version command: ${cmd.joinToString()}" }
     val result =
         process(
@@ -45,12 +45,19 @@ class BazelQueryService(
       throw RuntimeException("Bazel version command failed, exit code ${result.resultCode}")
     }
 
-    if (result.output.size != 1 || !result.output.first().startsWith("bazel ")) {
-      throw RuntimeException("Bazel version command returned unexpected output: ${result.output}")
-    }
+    // "bazel version" outputs "Build label: X.Y.Z" on one of the lines; accept that or legacy "bazel X.Y.Z".
+    val versionString =
+        result.output
+            .firstOrNull { it.startsWith("Build label: ") }
+            ?.removePrefix("Build label: ")?.trim()
+            ?: result.output
+                .firstOrNull { it.startsWith("bazel ") }
+                ?.removePrefix("bazel ")?.trim()
+            ?: throw RuntimeException(
+                "Bazel version command returned unexpected output: ${result.output}")
     // Trim off any prerelease suffixes (e.g., 8.6.0-rc1 or 8.6.0rc1).
-    val versionString = result.output.first().removePrefix("bazel ").trim().split('-')[0]
-    val version = versionString.split('.').map { it.takeWhile { c -> c.isDigit() }.toInt() }.toTypedArray()
+    val version =
+        versionString.split('-')[0].split('.').map { it.takeWhile { c -> c.isDigit() }.toInt() }.toTypedArray()
     return Triple(version[0], version[1], version[2])
   }
 

cli/src/main/kotlin/com/bazel_diff/bazel/BazelQueryService.kt

@@ -136,6 +136,37 @@ class E2ETest {
     testE2E(emptyList(), emptyList(), "/fixture/impacted_targets-1-2.txt")
   }
 
+  @Test
+  fun testDetermineBazelVersion() {
+    // E2E coverage for BazelQueryService.determineBazelVersion(): version is resolved lazily
+    // when the first query runs. Running generate-hashes to completion validates that
+    // "bazel version" is executed and parsed successfully (e.g. "Build label: X.Y.Z").
+    val projectA = extractFixtureProject("/fixture/integration-test-1.zip")
+    val workingDirectory = File(projectA, "integration")
+    val outputDir = temp.newFolder()
+    val outputPath = File(outputDir, "hashes.json")
+
+    val cli = CommandLine(BazelDiff())
+    val exitCode = cli.execute(
+        "generate-hashes",
+        "-w",
+        workingDirectory.absolutePath,
+        "-b",
+        "bazel",
+        outputPath.absolutePath)
+
+    assertThat(exitCode).isEqualTo(0)
+    assertThat(outputPath.readText().isNotEmpty()).isEqualTo(true)
+  }
+
+  @Test
+  fun testE2EWithNoKeepGoing() {
+    testE2E(
+        listOf("--no-keep_going"),
+        emptyList(),
+        "/fixture/impacted_targets-1-2.txt")
+  }
+
   @Test
   fun testE2EIncludingTargetType() {
     testE2E(
@@ -996,6 +1027,19 @@ class E2ETest {
     // which is designed to fail during analysis
     assertThat(exitCodeWithCquery).isEqualTo(1)
 
+    // Test with --no-keep_going: cquery should fail (no partial results, immediate failure)
+    val outputNoKeepGoing = File(outputDir, "hashes_no_keep_going.json")
+    val exitCodeWithNoKeepGoing = cli.execute(
+        "generate-hashes",
+        "-w",
+        workspace.absolutePath,
+        "-b",
+        "bazel",
+        "--useCquery",
+        "--no-keep_going",
+        outputNoKeepGoing.absolutePath)
+    assertThat(exitCodeWithNoKeepGoing).isEqualTo(1)
+
     // Test with --keep_going enabled (default behavior)
     // With keep_going, cquery returns partial results but still exits with code 1
     // The current implementation allows exit codes 0 and 3, but cquery with keep_going