Skip to content

Use --output=streamed_proto and --output_file if supported#278

Merged
tinder-maxwellelliott merged 1 commit into
Tinder:masterfrom
fmeum:output-file
Jul 8, 2025
Merged

Use --output=streamed_proto and --output_file if supported#278
tinder-maxwellelliott merged 1 commit into
Tinder:masterfrom
fmeum:output-file

Conversation

@fmeum
Copy link
Copy Markdown
Contributor

@fmeum fmeum commented Jul 7, 2025

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fmeum fmeum force-pushed the output-file branch 2 times, most recently from ab6de55 to 14a0334 Compare July 7, 2025 16:44
@fmeum fmeum changed the title Use modern cquery features Use --output=streamed_proto and --output_file if supported Jul 7, 2025
@fmeum fmeum marked this pull request as ready for review July 7, 2025 16:56
@fmeum
Copy link
Copy Markdown
Contributor Author

fmeum commented Jul 7, 2025

@tinder-maxwellelliott Could you unblock CI for me?

It looks like testing with Bazel 8 requires updating all the integration tests to have a MODULE.bazel file. Are they generated by a script?

@tinder-maxwellelliott
Copy link
Copy Markdown
Collaborator

tinder-maxwellelliott commented Jul 8, 2025

@tinder-maxwellelliott Could you unblock CI for me?

It looks like testing with Bazel 8 requires updating all the integration tests to have a MODULE.bazel file. Are they generated by a script?

Ill work on adding these tests

@tinder-maxwellelliott tinder-maxwellelliott merged commit bbb7ef4 into Tinder:master Jul 8, 2025
8 checks passed
@fmeum fmeum deleted the output-file branch July 8, 2025 04:00
@tinder-maxwellelliott tinder-maxwellelliott mentioned this pull request Apr 27, 2026
Merged
2 tasks
tinder-maxwellelliott added a commit that referenced this pull request Apr 27, 2026
@tinder-maxwellelliott @claude
Add e2e coverage for cquery streamed_proto path (#219) and bump to 19…
4a49bbe 
….0.1 (#333)

The fix for #219 (streamed_proto support for cquery) landed in #278;
this adds an explicit e2e test that exercises the --useCquery code path
to guard against regressions in the parseDelimitedFrom loop.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fmeum @CLAassistant @tinder-maxwellelliott