Fix empty query when using --excludeExternalTargets with --useCquery#280
Merged
tinder-maxwellelliott merged 1 commit intoJul 23, 2025
Conversation
|
|
6499dc8 to
fda7137
Compare
fda7137 to
b9d95d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where using
--excludeExternalTargetswith--useCquerywould cause bazel-diff to pass an empty query string tobazel query, resulting in a failure with exit code 2.The problem was that when external targets are excluded, the code was still trying to execute a query on an empty list, which produced an empty string. Now we check if there are actually any repo targets to query before executing the query, otherwise we just skip it and use an empty list.