Skip to content

Improve drawing of lines #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moreginger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve drawing of lines #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/draw/engine_display_draw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "draw/engine_display_draw.h"
#include "display/engine_display_common.h"
#include "debug/debug_print.h"
#include <math.h>
#include <string.h>
#include <stdlib.h>

Expand Down Expand Up @@ -58,12 +59,7 @@ void engine_draw_line(uint16_t color, float x_start, float y_start, float x_end,
float dy = y_end - y_start;

// See which axis requires most steps to draw complete line, store it
float step_count = 0.0f;
if(abs((int)dx) >= abs((int)dy)){
step_count = abs((int)dx);
}else{
step_count = abs((int)dy);
}
float step_count = ceilf(fmax(fabs(dx), fabs(dy)));

// Calculate how much to increment each axis each step
float slope_x = dx / step_count;
Expand All @@ -73,11 +69,11 @@ void engine_draw_line(uint16_t color, float x_start, float y_start, float x_end,
float line_y = y_start;

// Draw the line
for(uint32_t step=0; step<step_count; step++){
for(uint32_t step=0; step<=step_count; step++){
engine_draw_pixel(color, (int32_t)line_x, (int32_t)line_y, alpha, shader);

line_x = line_x + slope_x;
line_y = line_y + slope_y;

engine_draw_pixel(color, (int32_t)line_x, (int32_t)line_y, alpha, shader);
}
}

Expand Down Expand Up @@ -874,4 +870,4 @@ void engine_draw_filled_triangle_depth(texture_resource_class_obj_t *texture, ui
CAP_ROW += dx_ca;
ABP_ROW += dx_ab;
}
}
}