-
-
Notifications
You must be signed in to change notification settings - Fork 63
Properly populate JSONDecodeError & UnicodeDecodeError #46
Copy link
Copy link
Open
Labels
blockedBlocked by external projects (toolchains, OS issues, etc)Blocked by external projects (toolchains, OS issues, etc)bugSomething isn't workingSomething isn't workingupstream change requiredThis issue requires changes in the simdjson libraryThis issue requires changes in the simdjson library
Metadata
Metadata
Assignees
Labels
blockedBlocked by external projects (toolchains, OS issues, etc)Blocked by external projects (toolchains, OS issues, etc)bugSomething isn't workingSomething isn't workingupstream change requiredThis issue requires changes in the simdjson libraryThis issue requires changes in the simdjson library
We currently raise a ValueError instead of JSONDecodeError (which is a ValueError subclass) in some cases where JSONDecodeError would be more appropriate. This is because upstream simdjson does not report errors with enough granularity to populate
linenoandcolno(https://docs.python.org/3/library/json.html#json.JSONDecodeError)Might be viable to return 0 and 0 for now?