SuggestionsUpDownVoter should have UNKNOWN_MESSAGE exception gracefully with an INFO log instead #1414

Refactored and idomaticized

Author: Bryce72

application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java

@@ -57,12 +57,11 @@ public void onMessageReceived(MessageReceivedEvent event) {
 
     private static void createThread(Message message) {
         String threadTitle = generateThreadTitle(message);
-        message.createThreadChannel(threadTitle).queue(null, exception -> {
+        message.createThreadChannel(threadTitle).queue(_ -> {
+        }, exception -> {
             if (exception instanceof ErrorResponseException responseException
                     && responseException.getErrorResponse() == ErrorResponse.UNKNOWN_MESSAGE) {
-                logger.info(
-                        "Create Thread skipped: message was already deleted (likely by scamblocker) - ID: {}",
-                        message.getIdLong());
+                logger.info("Create Thread skipped: ID: {}", message.getIdLong());
                 return;
 
             }
@@ -102,24 +101,24 @@ private static void reactWith(String emojiName, Emoji fallbackEmoji, Guild guild
                     emojiName);
             return message.addReaction(fallbackEmoji);
         }).queue(ignored -> {
-        }, exception -> {
-            if (exception instanceof ErrorResponseException responseException) {
-                if (responseException.getErrorResponse() == ErrorResponse.REACTION_BLOCKED) {
-                    // User blocked the bot, hence the bot can not add reactions to their messages.
-                    // Nothing we can do here.
-                    return;
-                }
-                if (responseException.getErrorResponse() == ErrorResponse.UNKNOWN_MESSAGE) {
-                    logger.info(
-                            "Reaction skipped: message was already deleted (likely by scamblocker) - ID: {}",
-                            message.getIdLong());
-                    return;
-                }
+        }, exception -> handleReactionFailure(exception, message.getIdLong()));
+    }
+
+    private static void handleReactionFailure(Throwable exception, long messageId) {
+        if (exception instanceof ErrorResponseException responseException) {
+            if (responseException.getErrorResponse() == ErrorResponse.REACTION_BLOCKED) {
+                // User blocked the bot, hence the bot can not add reactions to their messages.
+                return;
             }
-            logger.error("Attempted to react to a suggestion, but failed", exception);
-        });
+            if (responseException.getErrorResponse() == ErrorResponse.UNKNOWN_MESSAGE) {
+                logger.info("Reaction skipped ID: {}", messageId);
+                return;
+            }
+        }
+        logger.error("Attempted to react to a suggestion, but failed", exception);
     }
 
+
     private static Optional<RichCustomEmoji> getEmojiByName(String name, Guild guild) {
         return guild.getEmojisByName(name, false).stream().findAny();
     }