Skip to content

Commit b321398

Browse files
committed
Fixed ScamDetector ignoring untrusted users and firing against trusted
1 parent 59c3daf commit b321398

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

application/src/main/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public ScamDetector(Config config) {
5353
public boolean isScam(Message message) {
5454
Member author = message.getMember();
5555
boolean isTrustedUser = author != null
56-
&& author.getRoles().stream().map(Role::getName).noneMatch(hasTrustedRole);
56+
&& author.getRoles().stream().map(Role::getName).anyMatch(hasTrustedRole);
5757
if (isTrustedUser) {
5858
return false;
5959
}

application/src/test/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetectorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ void ignoreTrustedUser() {
223223
boolean isScamResult = scamDetector.isScam(message);
224224

225225
// THEN flags it as harmless
226-
assertTrue(isScamResult);
226+
assertFalse(isScamResult);
227227
}
228228

229229
private static Message createMessageMock(String content, List<Message.Attachment> attachments) {

0 commit comments

Comments
 (0)