Improved the event reply with extracting the stream into a seperate variable, changing the logger inside the if condition and making the logger finall static, also renaming the magic number 200 to something more understandable MAX_TAGS_THRESHOLD_WARNING, and finally removing the ArrayList with provided value and using the direct value instead.

Author: DevSerendipity

application/src/main/java/org/togetherjava/tjbot/commands/tags/TagsCommand.java

@@ -4,15 +4,13 @@
 import net.dv8tion.jda.api.events.interaction.ButtonClickEvent;
 import net.dv8tion.jda.api.events.interaction.SlashCommandEvent;
 import org.jetbrains.annotations.NotNull;
+import org.slf4j.LoggerFactory;
 import org.togetherjava.tjbot.commands.SlashCommandAdapter;
 import org.togetherjava.tjbot.commands.SlashCommandVisibility;
 import org.togetherjava.tjbot.commands.utils.MessageUtils;
-
-import java.util.ArrayList;
+import org.slf4j.Logger;
 import java.util.List;
 import java.util.Objects;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 import java.util.stream.Collectors;
 
 /**
@@ -31,6 +29,7 @@
  */
 public final class TagsCommand extends SlashCommandAdapter {
     private final TagSystem tagSystem;
+    private static final Logger logger = LoggerFactory.getLogger(TagsCommand.class);
 
     /**
      * Creates a new instance, using the given tag system as base.
@@ -45,24 +44,25 @@ public TagsCommand(TagSystem tagSystem) {
 
     @Override
     public void onSlashCommand(@NotNull SlashCommandEvent event) {
+        int MAX_TAGS_THRESHOLD_WARNING = 200;
+        if (tagSystem.getAllIds().size() > MAX_TAGS_THRESHOLD_WARNING) {
+            // TODO Implement the edge case
 
-        ArrayList<String> list = new ArrayList<>(tagSystem.getAllIds());
-
-        if (list.size() > 200) {
-
-            Logger logger = Logger.getLogger(TagsCommand.class.getName());
-
-            logger.setLevel(Level.WARNING);
-            logger.warning("- WARNING - TAGS ARE BEYOND 200 LINES ");
+            logger.warn(
+                    "The amount of tags is very high and it might soon exceed the maximum character limit. The code should be adjusted to support this edge case soon.\n");
         }
+        String tagListText = tagSystem.getAllIds()
+            .stream()
+            .sorted()
+            .map(tag -> "* " + tag)
+            .collect(Collectors.joining("\n"));
 
-        event.replyEmbeds(MessageUtils.generateEmbed("All available tags",
-                        "* " + String.join("\n ",
-                                list.stream().sorted().collect(Collectors.joining("\n * "))),
-                        event.getUser(), TagSystem.AMBIENT_COLOR))
-                .addActionRow(
-                        TagSystem.createDeleteButton(generateComponentId(event.getUser().getId())))
-                .queue();
+        event
+            .replyEmbeds(MessageUtils.generateEmbed("All available tags", tagListText,
+                    event.getUser(), TagSystem.AMBIENT_COLOR))
+            .addActionRow(
+                    TagSystem.createDeleteButton(generateComponentId(event.getUser().getId())))
+            .queue();
     }
 
     @Override