Skip to content

Commit d4323eb

Browse files
committed
Reduce amount of public declarations and organize them
Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
1 parent dd4c251 commit d4323eb

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

application/src/main/java/org/togetherjava/tjbot/features/xkcd/XkcdCommand.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,15 @@ public final class XkcdCommand extends SlashCommandAdapter {
4444

4545
private static final Logger logger = LoggerFactory.getLogger(XkcdCommand.class);
4646

47-
public static final String COMMAND_NAME = "xkcd";
48-
public static final String SUBCOMMAND_RELEVANT = "relevant";
49-
public static final String SUBCOMMAND_CUSTOM = "custom";
50-
public static final String LAST_MESSAGES_AMOUNT_OPTION_NAME = "amount";
51-
public static final String XKCD_ID_OPTION_NAME = "id";
47+
private static final String COMMAND_NAME = "xkcd";
48+
private static final String SUBCOMMAND_RELEVANT = "relevant";
49+
private static final String SUBCOMMAND_CUSTOM = "custom";
50+
private static final String LAST_MESSAGES_AMOUNT_OPTION_NAME = "amount";
51+
private static final String XKCD_ID_OPTION_NAME = "id";
52+
private static final int MAXIMUM_MESSAGE_HISTORY = 100;
5253
private static final String VECTOR_STORE_XKCD = "xkcd-comics";
53-
public static final int MAXIMUM_MESSAGE_HISTORY = 100;
5454
private static final ChatGptModel CHAT_GPT_MODEL = ChatGptModel.FAST;
5555
private static final Pattern XKCD_POST_PATTERN = Pattern.compile("^\\D*(\\d+)");
56-
5756
private static final String CHATGPT_NO_ID_MESSAGE =
5857
"ChatGPT could not respond with a XKCD post ID.";
5958

application/src/main/java/org/togetherjava/tjbot/features/xkcd/XkcdRetriever.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,16 @@ public class XkcdRetriever {
4343
private static final HttpClient CLIENT =
4444
HttpClient.newBuilder().connectTimeout(Duration.ofSeconds(10)).build();
4545
private static final String XKCD_GET_URL = "https://xkcd.com/%d/info.0.json";
46-
public static final String SAVED_XKCD_PATH = "xkcd.generated.json";
46+
private static final String SAVED_XKCD_PATH = "xkcd.generated.json";
4747
private static final int XKCD_POSTS_AMOUNT = 3201;
4848
private static final int FETCH_XCKD_POSTS_POOL_SIZE = 20;
4949
private static final int FETCH_XKCD_POSTS_SEMAPHORE_SIZE = 10;
5050
private static final int FETCH_XKCD_POSTS_THREAD_SLEEP_MS = 50;
5151
private static final ObjectMapper objectMapper = new ObjectMapper();
5252

5353
private final Map<Integer, XkcdPost> xkcdPosts = new HashMap<>();
54-
private String xkcdUploadedFileId;
5554
private final ChatGptService chatGptService;
55+
private String xkcdUploadedFileId;
5656

5757
public XkcdRetriever(ChatGptService chatGptService) {
5858
this.chatGptService = chatGptService;

0 commit comments

Comments
 (0)