fix: double fire when channel is deleted (#1398)

* fix: add caffeine cache to prevent double fire

* fix: check is bot only on join

* feat: add synchronized keyword

* chore: try-catch the delete for extra protection

---------

Co-authored-by: Suraj Kumar <sk96.uk@gmail.com>

Author: tj-wazei

application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java

@@ -1,5 +1,7 @@
 package org.togetherjava.tjbot.features.voicechat;
 
+import com.github.benmanes.caffeine.cache.Cache;
+import com.github.benmanes.caffeine.cache.Caffeine;
 import net.dv8tion.jda.api.EmbedBuilder;
 import net.dv8tion.jda.api.entities.Guild;
 import net.dv8tion.jda.api.entities.Member;
@@ -20,6 +22,7 @@
 import org.togetherjava.tjbot.features.VoiceReceiverAdapter;
 
 import java.util.Optional;
+import java.util.concurrent.TimeUnit;
 
 /**
  * Handles dynamic voice channel creation and deletion based on user activity.
@@ -34,6 +37,9 @@ public final class DynamicVoiceChat extends VoiceReceiverAdapter {
     private final VoiceChatCleanupStrategy voiceChatCleanupStrategy;
     private final DynamicVoiceChatConfig dynamicVoiceChannelConfig;
 
+    private final Cache<Long, Boolean> deletedChannels =
+            Caffeine.newBuilder().expireAfterWrite(5, TimeUnit.MINUTES).build();
+
     /**
      * Creates a new instance of {@code DynamicVoiceChat}
      *
@@ -53,14 +59,10 @@ public void onVoiceUpdate(GuildVoiceUpdateEvent event) {
         Member member = event.getMember();
         User user = member.getUser();
 
-        if (user.isBot()) {
-            return;
-        }
-
         AudioChannelUnion channelJoined = event.getChannelJoined();
         AudioChannelUnion channelLeft = event.getChannelLeft();
 
-        if (channelJoined != null && isVoiceChannel(channelJoined)) {
+        if (channelJoined != null && isVoiceChannel(channelJoined) && !user.isBot()) {
             handleVoiceChannelJoin(event, channelJoined);
         }
 
@@ -77,7 +79,13 @@ private void handleVoiceChannelJoin(GuildVoiceUpdateEvent event,
         }
     }
 
-    private void handleVoiceChannelLeave(AudioChannelUnion channelLeft) {
+    private synchronized void handleVoiceChannelLeave(AudioChannelUnion channelLeft) {
+        long channelId = channelLeft.getIdLong();
+
+        if (Boolean.TRUE.equals(deletedChannels.getIfPresent(channelId))) {
+            return;
+        }
+
         if (!eventHappenOnDynamicRootChannel(channelLeft)) {
             logger.debug("Event happened on left channel {}", channelLeft);
 
@@ -91,7 +99,12 @@ private void handleVoiceChannelLeave(AudioChannelUnion channelLeft) {
                 if (messages.size() > 1) {
                     archiveDynamicVoiceChannel(channelLeft);
                 } else {
-                    channelLeft.delete().queue();
+                    deletedChannels.put(channelId, true);
+                    try {
+                        channelLeft.delete().queue();
+                    } catch (Exception _) {
+                        // Ignore
+                    }
                 }
             });
         }