CR added mapUserIdToMember utility to service

Author: Zabuzard

application/src/main/java/org/togetherjava/tjbot/features/tophelper/TopHelpersAssignmentRoutine.java

@@ -38,7 +38,6 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
-import java.util.function.Function;
 import java.util.function.Predicate;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
@@ -179,8 +178,7 @@ private void sendSelectionMenu(Collection<TopHelpersService.TopHelperStats> topH
                     .setMinValues(1)
                     .setMaxValues(topHelpers.size());
 
-        Map<Long, Member> userIdToMember =
-                members.stream().collect(Collectors.toMap(Member::getIdLong, Function.identity()));
+        Map<Long, Member> userIdToMember = TopHelpersService.mapUserIdToMember(members);
         topHelpers.stream()
             .map(topHelper -> topHelperToSelectOption(topHelper,
                     userIdToMember.get(topHelper.authorId())))

application/src/main/java/org/togetherjava/tjbot/features/tophelper/TopHelpersService.java

@@ -185,8 +185,7 @@ public static String asAsciiTable(Collection<TopHelperStats> topHelpers,
 
     private static String asAsciiTable(Collection<TopHelperStats> topHelpers,
             Collection<? extends Member> members, boolean includeIds) {
-        Map<Long, Member> userIdToMember =
-                members.stream().collect(Collectors.toMap(Member::getIdLong, Function.identity()));
+        Map<Long, Member> userIdToMember = mapUserIdToMember(members);
 
         List<List<String>> topHelpersDataTable = topHelpers.stream()
             .map(topHelper -> topHelperToDataRow(topHelper,
@@ -196,6 +195,16 @@ private static String asAsciiTable(Collection<TopHelperStats> topHelpers,
         return dataTableToString(topHelpersDataTable, includeIds);
     }
 
+    /**
+     * Given a list of members, maps them by their user ID.
+     * 
+     * @param members the members to map
+     * @return a map of user ID to corresponding member
+     */
+    public static Map<Long, Member> mapUserIdToMember(Collection<? extends Member> members) {
+        return members.stream().collect(Collectors.toMap(Member::getIdLong, Function.identity()));
+    }
+
     /**
      * Visual representation of the given members name as it should be used for display purposes.
      *