refactor: minor cleanups as requested

Author: SleepyStack

application/src/main/java/org/togetherjava/tjbot/features/Features.java

@@ -144,9 +144,9 @@ public static Collection<Feature> createFeatures(JDA jda, Database database, Con
         features.add(new HelpThreadActivityUpdater(helpSystemHelper));
         features
             .add(new AutoPruneHelperRoutine(config, helpSystemHelper, modAuditLogWriter, database));
+        features.add(new HelpThreadAutoArchiver(helpSystemHelper));
         HelpThreadCreatedListener helpThreadCreatedListener =
                 new HelpThreadCreatedListener(helpSystemHelper);
-        features.add(new HelpThreadAutoArchiver(helpSystemHelper));
         features.add(new LeftoverBookmarksCleanupRoutine(bookmarksSystem));
         features.add(new MarkHelpThreadCloseInDBRoutine(database, helpThreadLifecycleListener));
         features.add(new MemberCountDisplayRoutine(config));

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadAutoArchiver.java

@@ -55,7 +55,7 @@ public HelpThreadAutoArchiver(HelpSystemHelper helper) {
 
     @Override
     public String getName() {
-        return "thread-inactivity";
+        return "help-thread-auto-archiver";
     }
 
     @Override
@@ -70,25 +70,22 @@ public void acceptComponentIdGenerator(ComponentIdGenerator generator) {
 
     @Override
     public void onButtonClick(ButtonInteractionEvent event, List<String> args) {
-        if (args.contains(MARK_ACTIVE_ID)) {
-            onInactivityButton(event);
-        }
+        onMarkActiveButton(event);
     }
 
-    private void onInactivityButton(ButtonInteractionEvent event) {
+    private void onMarkActiveButton(ButtonInteractionEvent event) {
         event.deferEdit().queue();
 
-        if (event.getChannel() instanceof ThreadChannel thread) {
-            Message botClosedThreadMessage = event.getMessage();
+        ThreadChannel thread = event.getChannel().asThreadChannel();
+        Message botClosedThreadMessage = event.getMessage();
 
-            thread.getManager()
-                .setArchived(false)
-                .flatMap(_ -> botClosedThreadMessage.delete())
-                .queue();
+        thread.getManager()
+            .setArchived(false)
+            .flatMap(_ -> botClosedThreadMessage.delete())
+            .queue();
 
-            logger.debug("Thread {} was manually reactivated via button by user {}", thread.getId(),
-                    event.getUser().getId());
-        }
+        logger.debug("Thread {} was manually reactivated via button by user {}", thread.getId(),
+                event.getUser().getId());
     }
 
     @Override