fix(toxav): remove extra copy of video frame on encode#2900
Draft
Green-Sky wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
bug
Green-Sky
force-pushed
the
toxav_remove_img_copy_encode
branch
from
fa015c7 to
6cc2b37
Compare
Green-Sky
force-pushed
the
toxav_remove_img_copy_encode
branch
from
6cc2b37 to
9505c70
Compare
Green-Sky
force-pushed
the
toxav_remove_img_copy_encode
branch
2 times, most recently
from
07b7a06 to
1828c53
Compare
Green-Sky
force-pushed
the
toxav_remove_img_copy_encode
branch
from
1828c53 to
c9cdae0
Compare
Green-Sky
force-pushed
the
toxav_remove_img_copy_encode
branch
from
c9cdae0 to
9ed2fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested and works, but there might be alignment issues and other stuff.
I think we don't have alignment issues. I took a quick look at libvpx and arm neon loads and stores are unaligned, the avx code uses unaligned loads and stores. The example code also uses a mix of 1, 16 and 32 byte alignments.
Profiling flame graph of tomato sending 1080p@30hz with the removed section circled:
This change is