This repository was archived by the owner on Jan 28, 2026. It is now read-only.
Add missing px unit to width and height attributes#506
Open
astrotuna201 wants to merge 1 commit into
Open
Conversation
MaxDesiatov
changed the title
px unit to width and height attributes
MaxDesiatov
suggested changes
Jul 30, 2022
Collaborator
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
Would you be able to add a test (possibly a snapshot test if you find that more appropriate) to prevent regressions in the future? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes missing "px" units to width and height attribute, that resulted in attribute being dropped as invalid by browsers.