Skip to content

feat(shared): 玻璃态 Select 组件——PR #222 修复版#223

Merged
DeliciousBuding merged 1 commit into
dev/delicious233from
feat/fix-trump-select
May 28, 2026
Merged

feat(shared): 玻璃态 Select 组件——PR #222 修复版#223
DeliciousBuding merged 1 commit into
dev/delicious233from
feat/fix-trump-select

Conversation

@DeliciousBuding
Copy link
Copy Markdown
Collaborator

来源

PR #222(Xavier-Trump)的修复版。基于最新 dev/delicious233,修复了三个阻塞项。

相比 PR #222 的改进

阻塞项 修复
❌ 硬编码 rgba() 颜色 ✅ 全部替换为 OKLCH tokens(--border/--card/--popover/--ring)
❌ 无测试 ✅ 新增 Select.test.tsx(6 测试)
❌ 未 rebase ✅ 基于最新 dev/delicious233,零冲突
🐛 .chevon 拼写 ✅ 修正为 .chevron
🐛 z-index=10 过低 ✅ 使用 --z-overlay(30)

文件

  • Select.tsx(167 行,portal 下拉 + 键盘导航)
  • Select.module.css(OKLCH tokens + glassmorphism)
  • Select.test.tsx(渲染/键盘/onChange)

原 PR #222 的作者是 Xavier-Trump,本 PR 保留了他的作者署名。

从 PR #222 提取并修复:
- 所有 rgba() 替换为 OKLCH 设计 tokens(--border/--card/--popover/--ring)
- 修复 .chevon → .chevron CSS 拼写
- 修复 z-index 使用 --z-overlay(30) 替代 --z-dropdown(10)
- 新增 Select.test.tsx(6 测试:渲染、键盘导航、onChange)
- 添加到 shared/ui 导出

Co-Authored-By: Xavier-Trump <2933243959@qq.com>
Copilot AI review requested due to automatic review settings May 28, 2026 08:55
@DeliciousBuding DeliciousBuding merged commit 204e982 into dev/delicious233 May 28, 2026
6 of 10 checks passed
@DeliciousBuding DeliciousBuding deleted the feat/fix-trump-select branch May 28, 2026 08:55
@DeliciousBuding DeliciousBuding review requested due to automatic review settings May 28, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants