Skip to content

fix(desktop): 修复快捷键自定义态布局#282

Open
Xavier-Trump wants to merge 1 commit into
dev/trumpfrom
fix/desktop-keyboard-shortcut-edit-layout
Open

fix(desktop): 修复快捷键自定义态布局#282
Xavier-Trump wants to merge 1 commit into
dev/trumpfrom
fix/desktop-keyboard-shortcut-edit-layout

Conversation

@Xavier-Trump
Copy link
Copy Markdown
Collaborator

Summary

  • 修复 Settings -> Keyboard Shortcuts 点击“自定义…”后的裸文本渲染问题。
  • 为 KeyboardSection 自定义态补齐 .shortcutEdit* / .shortcutCapture* / .shortcutConflict 样式。
  • 新增 focused test 覆盖自定义态、捕获控件、冲突提示和 CSS module undefined class 回归。

Verification

  • cd app/desktop && corepack.cmd pnpm exec vitest run src/components/settings/sections/KeyboardSection.test.tsx --reporter=dot
  • cd app/desktop && corepack.cmd pnpm exec eslint src/components/settings/sections/KeyboardSection.tsx src/components/settings/sections/KeyboardSection.test.tsx src/components/settings/primitives/primitives.module.css
    • passed with warnings only: CSS ignored by eslint config; existing react-hooks/set-state-in-effect warning in KeyboardSection.
  • cd app/desktop && corepack.cmd pnpm typecheck
  • Playwright visual probe on http://127.0.0.1:5173/:
    • readonly screenshot: screenshots/keyboard-shortcuts-readonly.png
    • edit screenshot: screenshots/keyboard-shortcuts-edit.png
    • edit table display is grid, 14 rows and 14 edit buttons render inside the card, undefined class count is 0, no horizontal overflow, no console warnings/errors.

Subagent Reports

  • Worker: implemented CSS-only layout repair plus focused test; only touched Desktop settings shortcut files.
  • Tester: independently ran targeted tests, lint/typecheck, inspected diff, and verified UI with Playwright screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant