On plans: Long-press for removing, press for open recipe#999
Open
crosspolar wants to merge 2 commits into
Open
On plans: Long-press for removing, press for open recipe#999crosspolar wants to merge 2 commits into
crosspolar wants to merge 2 commits into
Conversation
2090f9f to
2e37116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, this is a frequently requested feature/fix, and I often encounter this issue as well. By simply swapping onLongPressed and Pressed, it also feels more consistent with the other pages (Recipes, Shopping list, etc.).
It resolves #821 and (at least partly) #959 + #179
@TomBursch , you've mentioned on the latter
You can open "Recent Recipes" on the same page with a single press and add them to your meal plan with a long press. So it would definitely be consistent if you could also remove recipes from your meal plan with a long press, right? It also makes it easy for users to distinguish between shopping list items and recipes.
Let me know what you think, I'm curious to hear your opinion.